Closed
Bug 1699445
Opened 5 years ago
Closed 4 years ago
FeatureGate needs to treat esr as a kind of release channel, else it will use the default value even if release uses a different value
Categories
(Toolkit :: FeatureGate, defect, P3)
Toolkit
FeatureGate
Tracking
()
RESOLVED
FIXED
102 Branch
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: aryx, Assigned: Gijs)
References
Details
Attachments
(1 file)
https://hg.mozilla.org/mozilla-central/file/caddf6de37fe837d216c3b0e88e9aacf79f5cebf/toolkit/components/featuregates/FeatureGate.jsm#l223
["release", AppConstants.MOZ_UPDATE_CHANNEL === "release"],
This means ESR will not be regarded as release and the default values from Features.toml will be used which can be the Nightly values (bug 1697781 fixed the only preference which was affected).
Should there be a check for release and esr having the same value or should release be true for the update channels release or esr?
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
Right in the nick of time for this ESR cycle this feels like a nice thing to fix...
|
||
Updated•4 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0cc5c2d11527
fix esr/release targeting of featuregates, r=mconley
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox102:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•