Closed Bug 1699460 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 28134 - [LayoutNG] Out-of-flow static position for legacy

Categories

(Core :: Layout: Columns, task, P4)

Product:
Core
Component:
Layout: Columns
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28134 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28134
Details from upstream follow.

b'Alison Maher <almaher@microsoft.com>' wrote:

[LayoutNG] Out-of-flow static position for legacy

When an out-of-flow positioned element's containing block is the
viewport, the static position gets re-computed using legacy layout.
There were a couple issues with how this was being computed for OOF
elements that were nested inside a multicol:

  1. SetStaticPositionFromNG() was not getting called for these OOF
    elements since the flow thread parent never matched any of the layout
    objects as the OOF was propagated up the tree. To fix this,
    SetStaticPositionFromNG() gets set if the parent is a flow thread
    and the current container object is a fragmentainer.

  2. The static position for elements after a spanner break were
    miscomputed since legacy expects the block offset to include the
    block contribution from previous columns. This is fixed by using
    the previous break token of the column to determine the expected
    static position to pass into SetStaticPositionFromNG().

Bug: 1188436
Change-Id: If7db7594772df8a0697427470e66ee0d5a9f8038
Reviewed-on: https://chromium-review.googlesource.com/2771079
WPT-Export-Revision: 075dfc0fd01cdcf08211725cca4b50ca96beda02

Component: web-platform-tests → Layout: Columns
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

PASS: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-multicol/abspos-after-spanner-static-pos.html: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/364b73173049
[wpt PR 28134] - [LayoutNG] Out-of-flow static position for legacy, a=testonly
https://hg.mozilla.org/integration/autoland/rev/84ce89ce986d
[wpt PR 28134] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/364b73173049
https://hg.mozilla.org/mozilla-central/rev/84ce89ce986d

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.