Closed Bug 1699515 Opened 3 years ago Closed 3 years ago

Consider react for rendering of Pocket button panels

Categories

(Firefox :: Pocket, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: thecount, Assigned: thecount)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

No description provided.
Depends on: 1701334
Priority: -- → P3
Assignee: nobody → sdowne
Status: NEW → ASSIGNED
Pushed by sdowne@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/98e7519f8247
Switching to react for Save to Pocket panels. r=gvn

Backed out for causing failures due to pocket/content/panels/js/home/overlay.js

[task 2021-11-10T01:34:06.686Z] 01:34:06     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 5, expected +0
[task 2021-11-10T01:34:06.686Z] 01:34:06     INFO - Stack trace:
[task 2021-11-10T01:34:06.687Z] 01:34:06     INFO - chrome://mochikit/content/browser-test.js:test_is:1364
[task 2021-11-10T01:34:06.687Z] 01:34:06     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:1020
[task 2021-11-10T01:34:06.687Z] 01:34:06     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-11-10T01:34:06.688Z] 01:34:06     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://pocket/content/panels/js/home/overlay.js -
[task 2021-11-10T01:34:06.688Z] 01:34:06     INFO - Stack trace:
[task 2021-11-10T01:34:06.688Z] 01:34:06     INFO - chrome://mochikit/content/browser-test.js:test_ok:1336
[task 2021-11-10T01:34:06.688Z] 01:34:06     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:1024
[task 2021-11-10T01:34:06.689Z] 01:34:06     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-11-10T01:34:06.689Z] 01:34:06     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://pocket/content/panels/js/main.js - 
[task 2021-11-10T01:34:06.689Z] 01:34:06     INFO - Stack trace:
[task 2021-11-10T01:34:06.689Z] 01:34:06     INFO - chrome://mochikit/content/browser-test.js:test_ok:1336
[task 2021-11-10T01:34:06.689Z] 01:34:06     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:1024
[task 2021-11-10T01:34:06.690Z] 01:34:06     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-11-10T01:34:06.691Z] 01:34:06     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://pocket/content/panels/js/messages.js - 
[task 2021-11-10T01:34:06.691Z] 01:34:06     INFO - Stack trace:
[task 2021-11-10T01:34:06.691Z] 01:34:06     INFO - chrome://mochikit/content/browser-test.js:test_ok:1336
[task 2021-11-10T01:34:06.691Z] 01:34:06     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:1024
[task 2021-11-10T01:34:06.691Z] 01:34:06     INFO - Not taking screenshot here: see the one that was previously logged
Flags: needinfo?(sdowne)
Pushed by sdowne@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/ff50f06b897f
Switching to react for Save to Pocket panels. r=gvn
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
Flags: needinfo?(sdowne)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: