Closed
Bug 1699515
Opened 3 years ago
Closed 3 years ago
Consider react for rendering of Pocket button panels
Categories
(Firefox :: Pocket, enhancement, P3)
Firefox
Pocket
Tracking
()
RESOLVED
FIXED
96 Branch
Tracking | Status | |
---|---|---|
firefox96 | --- | fixed |
People
(Reporter: thecount, Assigned: thecount)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Updated•3 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Assignee: nobody → sdowne
Status: NEW → ASSIGNED
Pushed by sdowne@getpocket.com: https://hg.mozilla.org/integration/autoland/rev/98e7519f8247 Switching to react for Save to Pocket panels. r=gvn
Comment 3•3 years ago
|
||
Backed out for causing failures due to pocket/content/panels/js/home/overlay.js
-
backout: https://hg.mozilla.org/integration/autoland/rev/f4170c272407aae380f211fbae005fc6914ed5ad
-
failure log: https://treeherder.mozilla.org/logviewer?job_id=357593242&repo=autoland&lineNumber=2873
[task 2021-11-10T01:34:06.686Z] 01:34:06 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 5, expected +0
[task 2021-11-10T01:34:06.686Z] 01:34:06 INFO - Stack trace:
[task 2021-11-10T01:34:06.687Z] 01:34:06 INFO - chrome://mochikit/content/browser-test.js:test_is:1364
[task 2021-11-10T01:34:06.687Z] 01:34:06 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:1020
[task 2021-11-10T01:34:06.687Z] 01:34:06 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-11-10T01:34:06.688Z] 01:34:06 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://pocket/content/panels/js/home/overlay.js -
[task 2021-11-10T01:34:06.688Z] 01:34:06 INFO - Stack trace:
[task 2021-11-10T01:34:06.688Z] 01:34:06 INFO - chrome://mochikit/content/browser-test.js:test_ok:1336
[task 2021-11-10T01:34:06.688Z] 01:34:06 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:1024
[task 2021-11-10T01:34:06.689Z] 01:34:06 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-11-10T01:34:06.689Z] 01:34:06 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://pocket/content/panels/js/main.js -
[task 2021-11-10T01:34:06.689Z] 01:34:06 INFO - Stack trace:
[task 2021-11-10T01:34:06.689Z] 01:34:06 INFO - chrome://mochikit/content/browser-test.js:test_ok:1336
[task 2021-11-10T01:34:06.689Z] 01:34:06 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:1024
[task 2021-11-10T01:34:06.690Z] 01:34:06 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-11-10T01:34:06.691Z] 01:34:06 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://pocket/content/panels/js/messages.js -
[task 2021-11-10T01:34:06.691Z] 01:34:06 INFO - Stack trace:
[task 2021-11-10T01:34:06.691Z] 01:34:06 INFO - chrome://mochikit/content/browser-test.js:test_ok:1336
[task 2021-11-10T01:34:06.691Z] 01:34:06 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:1024
[task 2021-11-10T01:34:06.691Z] 01:34:06 INFO - Not taking screenshot here: see the one that was previously logged
Flags: needinfo?(sdowne)
Pushed by sdowne@getpocket.com: https://hg.mozilla.org/integration/autoland/rev/ff50f06b897f Switching to react for Save to Pocket panels. r=gvn
Comment 5•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox96:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
Assignee | ||
Updated•2 years ago
|
Flags: needinfo?(sdowne)
You need to log in
before you can comment on or make changes to this bug.
Description
•