Closed Bug 1699554 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 28139 - [composite-bgcolor-animation] Fallback to main for table cases

Categories

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28139 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28139
Details from upstream follow.

b'Xida Chen <xidachen@chromium.org>' wrote:

[composite-bgcolor-animation] Fallback to main for table cases

For some cases such as putting background-color animation in the
table row, it would actually paint into the table cell. Therefore,
we won't paint the table row with the BackgroundColorPaintWorklet,
as a result, we won't have correct info to support the animation
on the compositor thread.

In this case, we should not composite the background-color animation.
This CL fixes it. It added 3 layout tests:
xxx-table1.html and xxx-table2.html crashes without this fix.
xxx-table3.html does not crash without this fix, but worth to
have coverage.

Bug: 1185643
Change-Id: I8bb836897d868d84471e90048a06e259e3a8c860
Reviewed-on: https://chromium-review.googlesource.com/2774182
WPT-Export-Revision: ca50ade2ce7e2713063fefc9b44a5e24244d4e7e

Component: web-platform-tests → Layout: Images, Video, and HTML Frames
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

PASS: 4

Chrome

PASS: 4

Safari

PASS: 4

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/82e59d2d5eb5 [wpt PR 28139] - [composite-bgcolor-animation] Fallback to main for table cases, a=testonly https://hg.mozilla.org/integration/autoland/rev/a04742f9f7a8 [wpt PR 28139] - Update wpt metadata, a=testonly
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4520b73d7d66 [wpt PR 28139] - [composite-bgcolor-animation] Fallback to main for table cases, a=testonly https://hg.mozilla.org/integration/autoland/rev/719d9520bf41 [wpt PR 28139] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/53c96c1e7935 [wpt PR 28139] - [composite-bgcolor-animation] Fallback to main for table cases, a=testonly https://hg.mozilla.org/integration/autoland/rev/ed9e450c9fd3 [wpt PR 28139] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a680ef90fb17 [wpt PR 28139] - [composite-bgcolor-animation] Fallback to main for table cases, a=testonly https://hg.mozilla.org/integration/autoland/rev/fa96a11a8d00 [wpt PR 28139] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.