1699557 - [Proton Address Bar] Spacing between Lock Icon and Text Input could be larger to match other icon spacing

Status: RESOLVED WONTFIX

(Firefox :: Address Bar, enhancement, P3)

Description

[Mehmet]

Attachment: actual_vs_expected.png

Nightly 88.0a1 (2021-03-18) (64-Bit)

STR:

1.) Type something into the Address Bar and press enter
2.) Focus the Address Bar so that the URL is highlighted
3.) Hover over the Lock Icon
4.) Compare spacing left right of the Lock icon

Actual: Left to the other icon is 16px; right to the Text Input is 8px

Expected: Right should also be 16px

A screenshot "actual_vs_expected" is attached.

Thanks.

Comment 1

[Mehmet]

Attachment: spacing_okay_between_chiclet_textinput.png

FYI: The spacing between the chiclets and text input looks correct as expected with 16px.

Comment 2

[Marco Bonardo [:mak]]

The spec tells me 8 to 10 pixels from the lock itself, it's not clear which of those is expected, they are a bit inconsistent on Figma and we may have to ask.

However, we must consider that what you are measuring here is only visible on hover, so it's not the most common situation. If we add more space to account for this normally non-visible padding, we risk to have the text far away from the icon itself in the most common case.
Indeed I'm looking at the current state without proton, and there's not really much space between the url and the permissions icon for example.

I'll mark this as an enhancement to be evaluated, I don't think it's a bug in itself.

Comment 3

[Marco Bonardo [:mak]]

(In reply to Mehmet from comment #1)

FYI: The spacing between the chiclets and text input looks correct as expected with 16px.

Yes, but in this case the background is visible, I assume the idea was to make consistent the space between visible objects, in the original case that is between the icon glyph and the text.
I'm not sure though, we should evaluate it.

Comment 4

[Mehmet]

Attachment: Bildschirmfoto 2021-03-18 um 21.48.03.png

Thanks for your feedback. Please feel free to close this report. I think this is only a "head-thing" for me, because the recent actual case in Non-Proton is, that there is a divider and the hover is narrower which makes things look better aligned.

Comment 5

[Marco Bonardo [:mak]]

I agree that for now this seems more a perception thing based on previous visuals, let's use Proton a bit to evaluate, we'll always have time to fix this space in case.

Comment 6

[Mehmet]

Sure, thanks.