1699575 - [wpt-sync] Sync PR 28142 - [flex] Don't stretch orthog. flex-items in column flexboxes.

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 28142 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28142
Details from upstream follow.

b'Ian Kilpatrick <[e-mail]>' wrote:

[flex] Don't stretch orthog. flex-items in column flexboxes.

Delete code - pass tests!

"!ShouldItemShrinkToFit()" was returning true for an orthogonal item
within a column flexbox. This in turn was getting it to stretch when
it shouldn't have. We now already set the "stretch" bit in the
appropriate places when stretching is occuring (previously stretch was
the default, not shrink-to-fit).

This removes the bad branch, and the complicated ShouldItemShrinkToFit()
function!

Bug: 1189046
Change-Id: Ib4b8762ce2999fe3690f9aa16d1925de53ce13a6

Reviewed-on: https://chromium-review.googlesource.com/2773659
WPT-Export-Revision: 17ba20470cb608b0b7f940f027f7188dfffc982a

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4392b142f32eaedb64068e815ba2ea3142cae2c2

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a5cb86d2a05
[wpt PR 28142] - [flex] Don't stretch orthog. flex-items in column flexboxes., a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0a5cb86d2a05