1699646 - Add Android device information to the profiler meta object

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P3)

Description

[Nazım Can Altınova [:canova]]

In the front-end issue :mcomella says that, when folks upload profiles, it's very common to have to ask, "Which device was this profile taken on?" to understand how to interpret the results. We should include the device info in the profile!

That's a great point, and it would be good to see that in the front-end. But we don't have that information currently in the profile data. We should add it to the meta object if we are in an android build. Looks like there are a few options like Build.MANUFACTURER, Build.DEVICE or Build.MODEL that we can use for this information.
See the docs: https://developer.android.com/reference/android/os/Build

Comment 1

[Nazım Can Altınova [:canova]]

Attachment: Bug 1699646 - Add Android device information to the profile meta object

Comment 2

[Nazım Can Altınova [:canova]]

Hi :mcomella, I just created a patch that adds this information to the profile json.

I've tried different options but ended up using Build.BRAND + Build.MODEL for this. For example, it's returning "motorola Moto G (5)" for the reference device I have (unfortunate that brand is lowercase, but we can change that in the front-end).

You've also mentioned about the Build.DEVICE before but when I was testing with this device, it returned cedric. It looks like this is the codename of this phone and not really user friendly. I wanted to see other phones and searched online, and I came across to these examples:

Samsung Galaxy S, 2.1update1
brand:Samsung
device:GT-I9000
model:GT-I9000

Nexus One, 2.2
brand:google
device:passion
model:Nexus One

So I think it looks like brand + model seems sensible. What do you think about these values? Do you think they are okay?

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I think brand + model seems sensible: I just checked and this is what glean uses. I remember one of the values returning something unintuitive so it must have been Build.DEVICE, based on your research.

Thanks for the quick turn around time!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c34db229aed2
Add Android device information to the profile meta object r=geckoview-reviewers,agi,gerald,julienw

Comment 5

[Nazım Can Altınova [:canova]]

Thanks for the answer! Just landed the back-end patch. I will create a front-end PR to show this information to the profiler info popup next.

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c34db229aed2