1699662 - ./mach lint -l clippy --verbose is failing on some directory

Status: NEW

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Sylvestre Ledru [:Sylvestre]]

To reproduce:

$ ./mach lint -l clippy --verbose -n toolkit/components/glean/                                                                                                                                        
12:06:05.673 clippy (644825) | Passing the following paths:
/home/sylvestre/dev/mozilla/autoland/toolkit/components/glean
12:06:05.776 clippy (644825) | Found version: clippy 0.0.212 (04488af 2020-08-24)

12:06:05.776 clippy (644825) | Found version: 2020.8.24. Minimal expected version: 2020.5.11
12:06:05.776 clippy (644825) | Path = /home/sylvestre/dev/mozilla/autoland/toolkit/components/glean
12:06:05.776 clippy (644825) | Path translated to = /home/sylvestre/dev/mozilla/autoland/toolkit/components/glean/Cargo.toml
12:06:05.776 clippy (644825) | Command: ['/home/sylvestre/.cargo/bin/cargo', 'clean', '--manifest-path', '/home/sylvestre/dev/mozilla/autoland/toolkit/components/glean/Cargo.toml']
12:06:05.862 clippy (644825) | Command: ['/home/sylvestre/.cargo/bin/cargo', 'clippy', '--message-format=json', '--manifest-path', '/home/sylvestre/dev/mozilla/autoland/toolkit/components/glean/Cargo.toml']
12:06:11.366 clippy (644825) | Command: ['/home/sylvestre/.cargo/bin/cargo', 'clean', '--manifest-path', '/home/sylvestre/dev/mozilla/autoland/toolkit/components/glean/Cargo.toml']
12:06:11.453 clippy (644825) | Could not parse the output:
12:06:11.453 clippy (644825) | clippy output: b'   Compiling proc-macro2 v1.0.20'
12:06:11.453 clippy (644825) | Could not parse the output:
12:06:11.453 clippy (644825) | clippy output: b'   Compiling unicode-xid v0.2.0'
12:06:11.454 clippy (644825) | Could not parse the output:
12:06:11.454 clippy (644825) | clippy output: b'   Compiling syn v1.0.40'
12:06:11.454 clippy (644825) | Could not parse the output:
12:06:11.454 clippy (644825) | clippy output: b'   Compiling autocfg v1.0.1 (/home/sylvestre/dev/mozilla/autoland/third_party/rust/autocfg)'
12:06:11.454 clippy (644825) | Could not parse the output:
12:06:11.454 clippy (644825) | clippy output: b'    Checking cfg-if v0.1.10'
12:06:11.454 clippy (644825) | Could not parse the output:
12:06:11.454 clippy (644825) | clippy output: b'   Compiling libc v0.2.74'
12:06:11.454 clippy (644825) | Could not parse the output:
12:06:11.454 clippy (644825) | clippy output: b'   Compiling serde_derive v1.0.116'
12:06:11.455 clippy (644825) | Could not parse the output:
12:06:11.455 clippy (644825) | clippy output: b'   Compiling bitflags v1.2.1'
12:06:11.455 clippy (644825) | Could not parse the output:
12:06:11.455 clippy (644825) | clippy output: b'   Compiling getrandom v0.1.14'
12:06:11.455 clippy (644825) | Could not parse the output:
12:06:11.455 clippy (644825) | clippy output: b'   Compiling serde v1.0.116'
12:06:11.455 clippy (644825) | Could not parse the output:
12:06:11.455 clippy (644825) | clippy output: b'    Checking matches v0.1.8'
12:06:11.455 clippy (644825) | Could not parse the output:
12:06:11.455 clippy (644825) | clippy output: b'   Compiling log v0.4.8'
12:06:11.456 clippy (644825) | Could not parse the output:
12:06:11.456 clippy (644825) | clippy output: b'   Compiling byteorder v1.3.2'
12:06:11.456 clippy (644825) | /home/sylvestre/dev/mozilla/autoland/third_party/rust/autocfg/src/lib.rs is not part of the list of files '/home/sylvestre/dev/mozilla/autoland/toolkit/components/glean'
12:06:11.456 clippy (644825) | /home/sylvestre/dev/mozilla/autoland/third_party/rust/autocfg/src/lib.rs is not part of the list of files '/home/sylvestre/dev/mozilla/autoland/toolkit/components/glean'
12:06:11.456 clippy (644825) | /home/sylvestre/dev/mozilla/autoland/third_party/rust/autocfg/src/lib.rs is not part of the list of files '/home/sylvestre/dev/mozilla/autoland/toolkit/components/glean'
12:06:11.456 clippy (644825) | /home/sylvestre/dev/mozilla/autoland/third_party/rust/autocfg/src/lib.rs is not part of the list of files '/home/sylvestre/dev/mozilla/autoland/toolkit/components/glean'
12:06:11.457 clippy (644825) | /home/sylvestre/dev/mozilla/autoland/third_party/rust/autocfg/src/lib.rs is not part of the list of files '/home/sylvestre/dev/mozilla/autoland/toolkit/components/glean'
12:06:11.457 clippy (644825) | /home/sylvestre/dev/mozilla/autoland/third_party/rust/autocfg/src/lib.rs is not part of the list of files '/home/sylvestre/dev/mozilla/autoland/toolkit/components/glean'
12:06:11.457 clippy (644825) | /home/sylvestre/dev/mozilla/autoland/third_party/rust/autocfg/src/lib.rs is not part of the list of files '/home/sylvestre/dev/mozilla/autoland/toolkit/components/glean'
12:06:11.457 clippy (644825) | Could not parse the output:
12:06:11.457 clippy (644825) | clippy output: b'   Compiling pkg-config v0.3.9'
12:06:11.457 clippy (644825) | Could not parse the output:
12:06:11.457 clippy (644825) | clippy output: b'   Compiling cc v1.0.59'
12:06:11.457 clippy (644825) | /home/sylvestre/dev/mozilla/autoland/third_party/rust/autocfg/src/lib.rs is not part of the list of files '/home/sylvestre/dev/mozilla/autoland/toolkit/components/glean'
12:06:11.458 clippy (644825) | /home/sylvestre/dev/mozilla/autoland/third_party/rust/autocfg/src/lib.rs is not part of the list of files '/home/sylvestre/dev/mozilla/autoland/toolkit/components/glean'
12:06:11.458 clippy (644825) | /home/sylvestre/dev/mozilla/autoland/third_party/rust/autocfg/src/lib.rs is not part of the list of files '/home/sylvestre/dev/mozilla/autoland/toolkit/components/glean'
12:06:11.458 clippy (644825) | /home/sylvestre/dev/mozilla/autoland/third_party/rust/autocfg/src/lib.rs is not part of the list of files '/home/sylvestre/dev/mozilla/autoland/toolkit/components/glean'
12:06:11.458 clippy (644825) | Could not parse the output:
[...]
12:06:11.462 clippy (644825) | clippy output: b'    Checking thin-vec v0.2.1'
12:06:11.462 clippy (644825) | Could not parse the output:
12:06:11.462 clippy (644825) | clippy output: b'    Checking threadbound v0.1.0'
12:06:11.462 clippy (644825) | Could not parse the output:
12:06:11.463 clippy (644825) | clippy output: b'    Checking static_prefs v0.1.0 (/home/sylvestre/dev/mozilla/autoland/modules/libpref/init/static_prefs)'
12:06:11.463 clippy (644825) | Error outside of clippy.This means that the build failed. Therefore, skipping this
12:06:11.463 clippy (644825) | File = /home/sylvestre/dev/mozilla/autoland/modules/libpref/init/static_prefs/src/lib.rs / Detail = {'rendered': 'error: environment variable `MOZ_TOPOBJDIR` not defined\n  --> modules/libpref/init/static_prefs/src/lib.rs:12:5\n   |\n12 |     env!("MOZ_TOPOBJDIR"),\n   |     ^^^^^^^^^^^^^^^^^^^^^\n   |\n   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)\n\n', 'children': [], 'code': None, 'level': 'error', 'message': 'environment variable `MOZ_TOPOBJDIR` not defined', 'spans': [{'byte_end': 464, 'byte_start': 443, 'column_end': 26, 'column_start': 5, 'expansion': {'def_site_span': {'byte_end': 28240, 'byte_start': 28105, 'column_end': 6, 'column_start': 5, 'expansion': None, 'file_name': '/rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libcore/macros/mod.rs', 'is_primary': False, 'label': None, 'line_end': 846, 'line_start': 843, 'suggested_replacement': None, 'suggestion_applicability': None, 'text': []}, 'macro_decl_name': 'env!', 'span': {'byte_end': 464, 'byte_start': 443, 'column_end': 26, 'column_start': 5, 'expansion': None, 'file_name': 'modules/libpref/init/static_prefs/src/lib.rs', 'is_primary': False, 'label': None, 'line_end': 12, 'line_start': 12, 'suggested_replacement': None, 'suggestion_applicability': None, 'text': [{'highlight_end': 26, 'highlight_start': 5, 'text': '    env!("MOZ_TOPOBJDIR"),'}]}}, 'file_name': 'modules/libpref/init/static_prefs/src/lib.rs', 'is_primary': True, 'label': None, 'line_end': 12, 'line_start': 12, 'suggested_replacement': None, 'suggestion_applicability': None, 'text': [{'highlight_end': 26, 'highlight_start': 5, 'text': '    env!("MOZ_TOPOBJDIR"),'}]}]}
12:06:11.463 clippy (644825) | Error outside of clippy.This means that the build failed. Therefore, skipping this
12:06:11.463 clippy (644825) | File = /home/sylvestre/dev/mozilla/autoland/modules/libpref/init/static_prefs/src/lib.rs / Detail = {'rendered': 'error: aborting due to previous error\n\n', 'children': [], 'code': None, 'level': 'error', 'message': 'aborting due to previous error', 'spans': []}
12:06:11.463 clippy (644825) | Could not parse the output:
12:06:11.463 clippy (644825) | clippy output: b'error: could not compile `static_prefs`.'
12:06:11.463 clippy (644825) | Could not parse the output:
12:06:11.463 clippy (644825) | clippy output: b''
12:06:11.464 clippy (644825) | Could not parse the output:
12:06:11.464 clippy (644825) | clippy output: b'To learn more, run the command again with --verbose.'
12:06:11.464 clippy (644825) | Could not parse the output:
12:06:11.464 clippy (644825) | clippy output: b'warning: build failed, waiting for other jobs to finish...'
12:06:11.464 clippy (644825) | Skipping the summary line {'rendered': 'warning: 11 warnings emitted\n\n', 'children': [], 'code': None, 'level': 'warning', 'message': '11 warnings emitted', 'spans': []} for file /home/sylvestre/dev/mozilla/autoland/third_party/rust/autocfg/src/lib.rs
12:06:11.464 clippy (644825) | Could not parse the output:
12:06:11.464 clippy (644825) | clippy output: b'error: build failed'
12:06:11.465 clippy (644825) | Finished in 5.79 seconds

Without verbose, we have the impression that the run was fine when it wasn't the case:

./mach lint -l clippy  -n toolkit/components/glean/                                                                                                                                                 ✖ 0 problems (0 errors, 0 warnings, 0 fixed)

We should either fix the build to make clippy run correctly or clearly fail mozlint