Closed Bug 1699671 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27907 - [composite-bgcolor-animation] Ensure ElementID for transparent background

Categories

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27907 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27907
Details from upstream follow.

b'Xida Chen <xidachen@chromium.org>' wrote:

[composite-bgcolor-animation] Ensure ElementID for transparent background

When we try to start a background color animation on the
compositor thread, the required UniqueId can be missing.

This CL fixes the problem by ensuring that the UniqueId
exists for the layout object that has background color
animation. In this way, it should fix all the cases where
we might miss a repaint.

Bug: 1184832
Change-Id: I0a4a675cbe979660de13867defb10b612edbbef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2739318
Commit-Queue: Xida Chen \<xidachen@chromium.org>
Reviewed-by: Robert Flack \<flackr@chromium.org>
Reviewed-by: Philip Rogers \<pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#864273}

Component: web-platform-tests → Layout: Images, Video, and HTML Frames
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

PASS : 1[Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 2[Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-windows10-64-opt] 3[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub]
FAIL : 1
TIMEOUT: 1[Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-windows10-64-opt] 2[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt]

Chrome

PASS : 3

Safari

PASS : 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-backgrounds/animations/background-color-animation-with-images.html: PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-opt] (Chrome: PASS, Safari: PASS)
/css/css-backgrounds/animations/background-color-animation-with-zero-alpha.html: PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], TIMEOUT [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: PASS, Safari: PASS)
/css/css-backgrounds/animations/background-color-transition-with-initially-transparent.html: FAIL [Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub] (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/124187061f38
[wpt PR 27907] - [composite-bgcolor-animation] Ensure ElementID for transparent background, a=testonly
https://hg.mozilla.org/integration/autoland/rev/2fa6f409eaa0
[wpt PR 27907] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.