1699677 - Mute/Unmute icon overlaps the site's favicon when PiP is enabled

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Simona Badau, Desktop QA]

Attachment: Audio indicator overlapping YouTube, Facebook and Twitch

Affected Versions:
Nightly 88.0a1

Tested On:
Windows 10
Ubuntu 20.04
Mac OS X 10.15

Steps to Reproduce:

1. Launch Firefox.
2. Go to a video sharing website (eg. www.youtube.com) and start a random video - with sound
3. Click on PiP toggle
4. Observe the mute/unmute icon from the tab

Expected:
The mute/unmute icon should be properly displayed in the tab so that the user can identify both the site's favicon and the sound icon.

Actual:
The mute/unmute icon overlaps the site's favicon making it unidentifiable.

Notes:
Mozregression found commit message:
Bug 1693066 - Implement new proton tab audio indicator design. r=jaws,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9a7dd526e56ca6c9c5a022a1aa74fa97dbc522ba&tochange=9afd696ad2b4d6050828a59306c27a9bff724dbc

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Heads up - this might be a regression from Proton changes.

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1699677 - Shift .tab-icon-overlay for non-proton PiP mode. r=jaws

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bad0916c8b1
Shift .tab-icon-overlay for non-proton PiP mode. r=jaws

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/5bad0916c8b1

Comment 5

[Negritas Sergiu, Desktop QA]

Hello I can confirm that this issue is fixed on al OS's with firefox 89.0a1(2021-03-23). Updating the flags accordingly.

While verifying this issue I also found another issue. Here is a link to it https://bugzilla.mozilla.org/show_bug.cgi?id=1700351

Thank you