169976 - IMAP offline:in stand alone mesg window, new folder still enabled

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect)

Description

[grylchan]

spun off bug 102284.

If you are offline and bring up a downloaded/non-downloaded
mail mesg in a stand alone window, the file menu item:
File|New folder is still enabled. It should be disabled.
The user can try to create a new folder but it won't work.

Comment 1

[Harry Lu]

I will paste a patch soon for review.

Comment 2

[Harry Lu]

Attachment: Patch V1

The patch from 102284 uses GetFolderTree() which is not supported in standalone
message window. It is only defined in msgMail3PaneWindow.js, not in
messageWindow.js. So there will be a javascript error when try to expand the
File-->New menu in standalone message window.
This patch uses GetSelectedMsgFolders() which is supported by both. The logic
is basically the same as the patch from 102284.
Please r= and sr= this patch. Thanks!

Comment 3

[Calvin Liu]

Harry, can we multi-select folders with current mozilla code?
The patch looks good. ssu, would you please give a r=?

Comment 4

[Sean Su]

looking at patch

Comment 5

[Sean Su]

Changed summary to reflect that this only needs to be fixed for IMAP accounts.
POP accounts work fine offline and online.

Comment 6

[Sean Su]

Comment on attachment 100214 [details] [diff] [review]
Patch V1

r=ssu

Comment 7

[Harry Lu]

Sean, thanks for you r=.
bienvenu, could you please sr= this patch when you have time?
Calvin, as I seen from current code, we don't support multiple select of folders
now. Thanks!

Comment 8

[David :Bienvenu]

Comment on attachment 100214 [details] [diff] [review]
Patch V1

sr=bienvenu

Comment 9

[Harry Lu]

Anto, since I don't have checkin permission now, could you please help me to
check in the patch when the tree is open and green today? Thanks!

Comment 10

[Antonio.Xu]

patch checked into trunk

Comment 11

[grylchan]

using commercial trunk:
2002-11-25-12-trunk/ on XP
2002-11-25-12-trunk/ on linux 2.2
2002-11-25-11-trunk/ on Mac 10.1.5

verified the following while offline:
  - stand alone mesg for either downloaded or non-downloaded mesg
     file|New folder is disabled
  - in main menu of 3 pane window, New folder for imap account is disabled
  - for pop accounts, new folder is enabled
        - 3 pane window
        - stand alone window

marking as verified.