1699892 - Hook up the server-side generated default FxA icons

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement, P3)

Description

[Sam Foster [:sfoster] (he/him)]

Once the work to implement the new alpha-numeric default avatar icons is complete on the server-side, we need to hook them up in the various FxA toolbar buttons and surfaces

Jira ticket for the server-side work: https://jira.mozilla.com/browse/FXA-3181

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Part of the work here will be to allow the domain that we serve the icons up from to use -moz-context-properties. I spoke to dholbert about this, and apparently this can be done by adding that domain to the allow-list in here somehow: https://searchfox.org/mozilla-central/rev/4e87b5392eafe1f1d49017e76f7317b06ec0b1d8/layout/svg/SVGContextPaint.cpp#28-74

This allow/disallow list is less about security, and more about making sure we don't accidentally ship this in a way that sites start using, since it's non-standard.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

The server-side FxA work is happening here: https://github.com/mozilla/fxa/pull/7972

Comment 3

[Danny Coates [:dcoates]]

The production domain for these images will be profile.accounts.firefox.com.

Comment 4

[Wil Clouser [:clouserw]]

Romain - this is almost ready to land on the server side and it will begin setting default avatars immediately. Do you need us to delay landing the change to coordinate with a date or Firefox launch?

Comment 5

[Romain Testard [:RT]]

(In reply to Wil Clouser [:clouserw] from comment #4)

Romain - this is almost ready to land on the server side and it will begin setting default avatars immediately. Do you need us to delay landing the change to coordinate with a date or Firefox launch?

Is this change impacting release or only nightly initially?
Did UX review the icons that are produced? (color, font, size....)?

Comment 6

[Romain Testard [:RT]]

It would be great if you could share sample icons so UX can review. Amy confirmed she had reviewed the sample available in Figma (circle with M).
Assuming UX is happy with the implementation it sounds like we should turn that on for nightly, I was assuming that this change would not make it, this is great!

Comment 7

[Wil Clouser [:clouserw]]

Yes, Danny worked with Amy on the icons. @danny - could you attach some samples here?

FxA is a website and doesn't differentiate Nightly or Release, so, when this lands it would go out to all users of FxA regardless of browser or device. Do you want us to delay landing or follow FxA's normal release schedule? (Right now that would have this live around April 21)

Comment 8

[Danny Coates [:dcoates]]

Attachment: monograms.png

Here's a monogram avatar with context-fill enabled/disabled for a few themes.

Comment 9

[Romain Testard [:RT]]

(In reply to Wil Clouser [:clouserw] from comment #7)

Yes, Danny worked with Amy on the icons. @danny - could you attach some samples here?

FxA is a website and doesn't differentiate Nightly or Release, so, when this lands it would go out to all users of FxA regardless of browser or device. Do you want us to delay landing or follow FxA's normal release schedule? (Right now that would have this live around April 21)

Thanks will, it sounds like we could deploy to all channels but is there a way we could test this first?

Comment 10

[Wil Clouser [:clouserw]]

Once we land it, it will be on our staging server. Do you have someone in QA you'd like us to ping once it is on staging?

Comment 11

[Mike Conley (:mconley) (:⚙️)]

ni'ing tracy on comment 10

Comment 12

[Tracy Walker [:tracy]]

(In reply to Wil Clouser [:clouserw] from comment #10)

Once we land it, it will be on our staging server. Do you have someone in QA you'd like us to ping once it is on staging?

Yes, Alin is already cc'd here.

Comment 13

[Danny Coates [:dcoates]]

For testing, Firefox needs to be configured with the stage FxA servers. Us devs usually use fxa-dev-launcher to do it automatically. https://github.com/mozilla/fxa/blob/main/packages/fxa-dev-launcher/README.md

Comment 14

[Wil Clouser [:clouserw]]

This is on our staging server, scheduled to go out around April 21. Alin - could you look at this?

Comment 15

[Mike Conley (:mconley) (:⚙️)]

Out of curiosity, what is the domain for the staging server?

Comment 16

[Wil Clouser [:clouserw]]

Ah, I thought Danny's link up there would have it, but it's pretty barebones. Stage is at https://accounts.stage.mozaws.net/ . Rebecca Billings would have more testing docs if they are needed (and we're in #fxa).

Comment 17

[Alin Ilea, Desktop QA]

Sure, I'll take a look. Thanks!

Comment 18

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1699892 - Allow the Firefox Accounts avatar server to use SVG context properties. r?dholbert!

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbce2c52a886
Allow the Firefox Accounts avatar server to use SVG context properties. r=dholbert

Comment 20

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bbce2c52a886

Comment 21

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9214217 [details]
Bug 1699892 - Allow the Firefox Accounts avatar server to use SVG context properties. r?dholbert!

Beta/Release Uplift Approval Request

• User impact if declined: Firefox Accounts users using the built-in light theme with no custom avatar set will have a harder time seeing the new monogrammed avatar when the panel is open. The new monogrammed avatar hasn't shipped yet, but will likely ship soon.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is well contained, well understood code, with an automated test.
• String changes made/needed: None.

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9214217 [details]
Bug 1699892 - Allow the Firefox Accounts avatar server to use SVG context properties. r?dholbert!

Unfortunate that we can't segment by train, but glad we got it sorted now in the cycle. Approved for 88.0b9. Is this needed on ESR78 also?

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2251c12dfb87

Comment 24

[Mike Conley (:mconley) (:⚙️)]

Hm... I guess, that makes sense, yes.

Comment 25

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9214217 [details]
Bug 1699892 - Allow the Firefox Accounts avatar server to use SVG context properties. r?dholbert!

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This isn't a security bug, but we might want to consider it for aesthetics, since it will mean that in Light Mode, the default FxA avatar will be hard to see.
• User impact if declined: See beta uplift request.
• Fix Landed on Version: 89
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): See beta uplift request.
• String or UUID changes made by this patch: None.

Comment 26

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9214217 [details]
Bug 1699892 - Allow the Firefox Accounts avatar server to use SVG context properties. r?dholbert!

Approved for 78.10esr too, thanks.

Comment 27

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9214217 [details]
Bug 1699892 - Allow the Firefox Accounts avatar server to use SVG context properties. r?dholbert!

Approved for 78.10esr.

Comment 28

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/48ba26e780c2