1699924 - The patch for bug 1174332 doesn't seem correct to me.

Status: NEW

(Core :: Web Painting, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

See data:text/html,<input style="box-shadow: 0 0 5px blue">. When you focus the input then the shadow moves to be outside the outline, which I think is incorrect and bad.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Markus, should we revert that? Leave that only when the mac native theme is in use somehow? Thanks.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

It seems Safari avoids painting shadows on native buttons altogether for example.

Comment 3

[Markus Stange [:mstange]]

So the expectation of that patch was that, whenever we hit the nativeTheme == true path, box-shadow drawing ignores the rect and the border-radius and instead acts like a filter on the appearance drawing. And the patch adjusted the rects so that the output of that "filter" wasn't clipped. Even before the patch, we would include the focus ring in the input of the box-shadow "filter" because the focus ring is drawn as part of the appearance drawing.
So all that patch changed (if the expectation was correct) was that the output was no longer clipped.

Oh, I just found bug 1327935 comment 2 which basically said the same thing.

I think it would be good to remove our special "native theme box-shadow" path. The other options are:

• Draw no box-shadow, like Safari. But then we need to change our invalid form styling which currently makes use of red box-shadows, IIRC.
• Draw a box-shadow around a (rounded?) rectangle that is somehow tight around the form control. For example, when there's a checkbox whose border box has an aspect ratio of 2:1, the checkbox drawing itself is square and centered in that box, and we shouldn't draw a shadow based on a 2:1 box.

Comment 4

[Markus Stange [:mstange]]

The special native theme box-shadow drawing is from bug 581222.