1699930 - text-scaling-factor incorrectly affects size of UI elements such as scrollbars

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Simonas Kazlauskas [:nagisa/:simukis]]

Attachment: Poor looking scrollbars and weird UI element scale

I have set the following system-wide property:

gsettings set org.gnome.desktop.interface text-scaling-factor 1.5

Firefox picks it up and derives its own devPixelPerCss from this. Afterwards the UI elements and scrollbars will be scaled accordingly, which is not what native GTK applications do. The newly implemented scrollbars look pretty jarring, for instance (see the attached screenshot).

This is not an issue that affects scrollbars in current stable firefox.

Comment 1

[Simonas Kazlauskas [:nagisa/:simukis]]

Attachment: Poor looking scrollbars and weird UI element scale

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Thanks for filing, will take a look. As a workaround you can customize the scrollbar size changing widget.non-native-theme.scrollbar.size.

Comment 3

[Simonas Kazlauskas [:nagisa/:simukis]]

Setting widget.non-native-theme.scrollbar.size to 12 / text-scaling-factor = 8 does produce very native-looking results.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1699930 - Don't let GTK text scale affect non-native scrollbar sizes. r=mstange

This matches the native theme. We plumb it via LookAndFeel to avoid
having to load GTK settings in child processes.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71f00533fc8e
Don't let GTK text scale affect non-native scrollbar sizes. r=mstange

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/71f00533fc8e