1699931 - Different radius for checked and unchecked checkbox.

Status: RESOLVED FIXED

(Core :: Widget, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1699931 - Fix checked checkbox radius in the non-native theme. r=mstange

This also uncovered a minor issue with WebRender disabled where the
radii was slightly off because it wasn't accounting for the border.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c793fb0c34e0
Fix checked checkbox radius in the non-native theme. r=mstange

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out changeset for Android reftest failures on element-paint-native-widget.html.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=c793fb0c34e00e6e498a6640b236aa44bb2ad453&selectedTaskRun=LX4670sRTjCdgzZB8lMsTA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=333883021&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/f9a8084eb0f3a114e60b4034cbf4e79d1c953046

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0489ddac64f
Fix checked checkbox radius in the non-native theme. r=mstange

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57a6343b7bfc
Fix 1212823-2-ref.html to actually match the border radius we use on the non-native theme.
https://hg.mozilla.org/integration/autoland/rev/ff337e5e75b2
Annotate element-paint-native-widget for less fuzziness now that WR and fallback agree on the radius.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efcebefa19c0
A couple other fuzz tweaks.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d08490cb7ac7
Annotate a test that's less fuzzy.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2f8f9a311a7
A couple more fuzzy annotation changes.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d612680ffc4
Hopefully the last fuzzy annotation change...

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e0489ddac64f
https://hg.mozilla.org/mozilla-central/rev/57a6343b7bfc
https://hg.mozilla.org/mozilla-central/rev/ff337e5e75b2
https://hg.mozilla.org/mozilla-central/rev/efcebefa19c0
https://hg.mozilla.org/mozilla-central/rev/d08490cb7ac7
https://hg.mozilla.org/mozilla-central/rev/a2f8f9a311a7
https://hg.mozilla.org/mozilla-central/rev/0d612680ffc4

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1697210