1700001 - [Linux][Proton] "Exit" appmenu item should be labeled "Quit" instead

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P2)

Description

[Asif Youssuff]

Noticed this on Linux.

mozregression initally pointed to bug 1695348 but eventually got to:

8:43.76 INFO: No more integration revisions, bisection finished.
8:43.76 INFO: Last good revision: f456a37c71fcbf9aebd055c368d4cf4df4fdac46
8:43.76 INFO: First bad revision: 563591e6ddec99ae86785df983d450e061ee0595
8:43.76 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f456a37c71fcbf9aebd055c368d4cf4df4fdac46&tochange=563591e6ddec99ae86785df983d450e061ee0595

Steps to reproduce:

1. Set browser.proton.enabled to true
2. restart Firefox
3. click on app menu, dismiss app menu
4. press alt and click file menu

What happens:

Notice that the keyboard shortcut for both "Exit" (appmenu) and "Quit" (File menu) is Ctrl-q,

Expected result:

Appmenu shows "Quit" instead of "Exit" to match the keyboard shortcut and the File menu.

Comment 1

[:Gijs (he/him)]

Asif suggested he can contribute a fix here.

To address this, I guess we can either duplicate https://searchfox.org/mozilla-central/rev/36f79bed679ad7ec46f7cd05868a8f6dc823e1be/browser/locales/en-US/browser/appmenu.ftl#27-28 or rev the string identifier and then use a PLATFORM() construct to use a different text depending on the OS. Either way we'd need to update https://searchfox.org/mozilla-central/rev/36f79bed679ad7ec46f7cd05868a8f6dc823e1be/browser/base/content/browser.xhtml#1092 - in the former case with an ifdef, in the latter with just a new string ID. :flod, is there a preference from the l10n perspective for different fluent messages or just 1?

Comment 2

[Francesco Lodolo [:flod]]

I think it would be fine to use the PLATFORM() on a new string (2nd option), so that locales can drop the variants if needed (some don't have different terminology between Windows an Linux).

Comment 3

[Asif Youssuff]

Attachment: Bug 1700001 - Added quit option for appmenu in Linux r?gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22bd81fc283e
Added quit option for appmenu in Linux r=flod

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/22bd81fc283e

Comment 6

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Nightly build 89.0a1 (2021-04-18). "Quit" is displayed in AppMenu as well in the Menu Bar -> File along with the Ctrl+Q keyboard shortcut using Ubuntu 20.04.