Closed Bug 1700001 Opened 2 years ago Closed 2 years ago

[Linux][Proton] "Exit" appmenu item should be labeled "Quit" instead

Categories

(Firefox :: Menus, defect, P2)

Product:
Firefox
Component:
Menus
Platform:
Desktop
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- disabled
firefox88 --- disabled
firefox89 --- verified

People

(Reporter: yoasif, Assigned: yoasif, Mentored)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: nightly-community, regression, ux-consistency, Whiteboard: [proton-hamburger-menu])

Attachments

(1 file)

Bug 1700001 - Added quit option for appmenu in Linux r?gijs
48 bytes, text/x-phabricator-request
Details | Review

Noticed this on Linux.

mozregression initally pointed to bug 1695348 but eventually got to:

8:43.76 INFO: No more integration revisions, bisection finished.
8:43.76 INFO: Last good revision: f456a37c71fcbf9aebd055c368d4cf4df4fdac46
8:43.76 INFO: First bad revision: 563591e6ddec99ae86785df983d450e061ee0595
8:43.76 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f456a37c71fcbf9aebd055c368d4cf4df4fdac46&tochange=563591e6ddec99ae86785df983d450e061ee0595

Steps to reproduce:

  1. Set browser.proton.enabled to true
  2. restart Firefox
  3. click on app menu, dismiss app menu
  4. press alt and click file menu

What happens:

Notice that the keyboard shortcut for both "Exit" (appmenu) and "Quit" (File menu) is Ctrl-q,

Expected result:

Appmenu shows "Quit" instead of "Exit" to match the keyboard shortcut and the File menu.

Blocks: proton-hamburger-menu
Has Regression Range: --- → yes
Has STR: --- → yes
Keywords: nightly-community, ux-consistency
Regressed by: 1688700
Severity: -- → S3
status-firefox88: affected → disabled
status-firefox89: --- → affected
OS: Unspecified → Linux
Priority: -- → P2
Hardware: Unspecified → Desktop
Summary: "Exit" appmenu item is inconsistent with File > Quit and with keyboard shortcut (Ctrl-q) → [Linux][Proton] "Exit" appmenu item should be labeled "Quit" instead
Whiteboard: [proton-hamburger-menu]

Asif suggested he can contribute a fix here.

To address this, I guess we can either duplicate https://searchfox.org/mozilla-central/rev/36f79bed679ad7ec46f7cd05868a8f6dc823e1be/browser/locales/en-US/browser/appmenu.ftl#27-28 or rev the string identifier and then use a PLATFORM() construct to use a different text depending on the OS. Either way we'd need to update https://searchfox.org/mozilla-central/rev/36f79bed679ad7ec46f7cd05868a8f6dc823e1be/browser/base/content/browser.xhtml#1092 - in the former case with an ifdef, in the latter with just a new string ID. :flod, is there a preference from the l10n perspective for different fluent messages or just 1?

Assignee: nobody → yoasif
Mentor: gijskruitbosch+bugs
Flags: needinfo?(francesco.lodolo)

I think it would be fine to use the PLATFORM() on a new string (2nd option), so that locales can drop the variants if needed (some don't have different terminology between Windows an Linux).

Flags: needinfo?(francesco.lodolo)
Pushed by flodolo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/22bd81fc283e
Added quit option for appmenu in Linux r=flod

https://hg.mozilla.org/mozilla-central/rev/22bd81fc283e

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox89: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Verified - Fixed in latest Nightly build 89.0a1 (2021-04-18). "Quit" is displayed in AppMenu as well in the Menu Bar -> File along with the Ctrl+Q keyboard shortcut using Ubuntu 20.04.

Status: RESOLVED → VERIFIED
status-firefox89: fixed → verified
You need to log in before you can comment on or make changes to this bug.