1700092 - Expose watcherTraits in target actors

Status: RESOLVED FIXED

(DevTools :: Style Editor, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

In Bug 1685268, we're going to introduce a temporary solution to check if a watcher has support for stylesheet resources. When Bug 1644397 lands we should be able to refactor that by exercising addDataEntry instead (when the pref we're setting in Bug 1644397 is set to true).

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1700092 - [devtools] Add SUPPORTED_RESOURCES watcherData and use it to check stylesheet watcher support

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

The situation changed since last year. We now pass around a sessionContext object to the content processes, so we can put the watcherTraits there.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1700092 - [devtools] Add supported targets and resources to session context. r=bomsy,ochameau.

This allows us to simplify and fix hasStyleSheetWatcherSupportForTarget.

In the browser toolbox, since we're in a "all" session context type, TargetActorRegistry.getTargetActors
would only return an array of a single element, the parent process target.
In case of window global targets, in the browser toolbox context, we wouldn't
find the target we're looking for, which was making hasStyleSheetWatcherSupportForTarget
return false.

We can now simply look into the sessionContext watcherTraits property.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea32c4c1d987
[devtools] Add supported targets and resources to session context. r=bomsy,ochameau.

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ea32c4c1d987