Consolidate and rename browser/themes/shared icons
Categories
(Firefox :: Theme, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox91 | --- | verified |
People
(Reporter: sfoster, Assigned: sfoster)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-icons])
Attachments
(1 file)
Ahead of the proton icon updates, we want to align icons on a naming convention like so:
{base name}-{state}-{style}-{size}.svg
To reduce churn and noise, I suggest leaving the default size, state, style off. So, e.g. check.svg remains check.svg. We'll also eliminate some duplicates that aren't specifically called out in other bugs.
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Moving this to cleanup. We'll get the new icons in place at their existing paths first, and edit the allowed-dupes list as necessary leaving this as cleanup work for later.
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
After talking with a :harry and others, I don't think it makes sense to do a mass renaming to align our assets with this naming convention. When the opportunity comes up we should move towards that convention, in individual bugs as needed. Likewise, consolidation of icons needs separate bugs & patches case by case.
Assignee | ||
Comment 3•3 years ago
|
||
Looks like there's one entry (glyph-add-16.svg / zoom-in.svg) in the allowed-duped.mn file that lists this bug, so I can do that here.
Both are actually dupes of toolkit/themes/shared/add.svg, but the allowed-dupes script doesn't catch them because of some minor attribute differences.
Assignee | ||
Comment 4•3 years ago
|
||
- Use toolkit's add.svg for the zoom-in buttons and about:newtab's add icon
Updated•3 years ago
|
Comment 6•3 years ago
|
||
bugherder |
Comment 7•3 years ago
|
||
Hi Sam, other than the add.svg for the zoom-in buttons and about:newtab's add icon, are there any icons affected by this fix ? any other icons removed ?
Assignee | ||
Comment 8•3 years ago
|
||
(In reply to Rares Doghi from comment #7)
Hi Sam, other than the add.svg for the zoom-in buttons and about:newtab's add icon, are there any icons affected by this fix ? any other icons removed ?
- Mac touch bar new tab button
- New tab button in the tab strip
- about:newtab add icon
- zoom-in buttons
- about:config add new pref button
Comment 9•3 years ago
|
||
Thanks Sam, This issue is Verified as fixed in our latest Nightly build 92.0a1 (2021-07-14) as well as Beta 91.0b2 on Windows, Mac and Ubuntu.
Description
•