Closed Bug 1700124 Opened 9 months ago Closed 5 months ago

Consolidate and rename browser/themes/shared icons

Categories

(Firefox :: Theme, task, P3)

task

Tracking

()

VERIFIED FIXED
91 Branch
Tracking Status
firefox91 --- verified

People

(Reporter: sfoster, Assigned: sfoster)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-icons])

Attachments

(1 file)

Ahead of the proton icon updates, we want to align icons on a naming convention like so:

{base name}-{state}-{style}-{size}.svg

To reduce churn and noise, I suggest leaving the default size, state, style off. So, e.g. check.svg remains check.svg. We'll also eliminate some duplicates that aren't specifically called out in other bugs.

No longer depends on: 1699624
Assignee: nobody → sfoster
Status: NEW → ASSIGNED
Priority: P1 → P3

Moving this to cleanup. We'll get the new icons in place at their existing paths first, and edit the allowed-dupes list as necessary leaving this as cleanup work for later.

Assignee: sfoster → nobody
Status: ASSIGNED → NEW
Assignee: nobody → sfoster
Status: NEW → ASSIGNED

After talking with a :harry and others, I don't think it makes sense to do a mass renaming to align our assets with this naming convention. When the opportunity comes up we should move towards that convention, in individual bugs as needed. Likewise, consolidation of icons needs separate bugs & patches case by case.

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → WONTFIX

Looks like there's one entry (glyph-add-16.svg / zoom-in.svg) in the allowed-duped.mn file that lists this bug, so I can do that here.
Both are actually dupes of toolkit/themes/shared/add.svg, but the allowed-dupes script doesn't catch them because of some minor attribute differences.

Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
  • Use toolkit's add.svg for the zoom-in buttons and about:newtab's add icon
Attachment #9228620 - Attachment description: Bug 1700124 - de-duplicate add (+) icons. r?thecount,harry → Bug 1700124 - de-duplicate add (+) icons r?thecount,harry
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81168fdd4e18
de-duplicate add (+) icons r=thecount,harry,desktop-theme-reviewers
Status: REOPENED → RESOLVED
Closed: 5 months ago5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

Hi Sam, other than the add.svg for the zoom-in buttons and about:newtab's add icon, are there any icons affected by this fix ? any other icons removed ?

Flags: needinfo?(sfoster)

(In reply to Rares Doghi from comment #7)

Hi Sam, other than the add.svg for the zoom-in buttons and about:newtab's add icon, are there any icons affected by this fix ? any other icons removed ?

  • Mac touch bar new tab button
  • New tab button in the tab strip
  • about:newtab add icon
  • zoom-in buttons
  • about:config add new pref button
Flags: needinfo?(sfoster)

Thanks Sam, This issue is Verified as fixed in our latest Nightly build 92.0a1 (2021-07-14) as well as Beta 91.0b2 on Windows, Mac and Ubuntu.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.