Closed Bug 1700141 Opened 9 months ago Closed 8 months ago

Use proton checkbox styling in in-content pages (so they look OK in modals)

Categories

(Firefox :: Theme, defect, P1)

Desktop
All
defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: Gijs, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Keywords: helpwanted, Whiteboard: [proton-foundations][proton-modals])

Attachments

(1 file)

In bug 1697315 we added some proton styles for checkboxes. They don't apply to modals right now, because those are using in-content stylesheets.

Now that we have pretty checkboxes in chrome we should ensure that the in-content styles get the benefit of those.

Whiteboard: [proton-foundations]
See Also: → 1699426

This should be doable by ensuring the checkbox styling in https://searchfox.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css doesn't override the bits of the main checkbox styling that we want.

Keywords: helpwanted
Summary: Use proton checkbox styling in in-content pages → Use proton checkbox styling in in-content pages (so they look OK in modals)
Whiteboard: [proton-foundations] → [proton-foundations][proton-modals]

Are we certain this should be a P1? This seems like clean-up to me...

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #2)

Are we certain this should be a P1? This seems like clean-up to me...

Right now the modals don't have the new checkbox styles, and this was raised by product in bug 1699426 as part of a number of styling updates that block shipping, and I split the checkbox stuff into this bug, which I therefore also assumed should be P1. Does that make sense?

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(mconley)

Yep. I'll take a crack at this.

Assignee: nobody → mconley
Flags: needinfo?(mconley)

This patch grafts the Proton checkbox styles onto input[type="checkbox"] for common.css
pages if Proton is enabled, and inherits the Proton styling for XUL checkboxes.

If Proton is not enabled, it uses the pre-Proton styles for both XUL checkboxes and
input[type="checkbox"].

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f45123dd0cce
Use Proton checkboxes for in-content pages when Proton is enabled. r=Itiel,desktop-theme-reviewers

Backed out changeset f45123dd0cce (Bug 1700141) for causing bc failures in browser_parsable_css.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/49d2793258e9f91302a2000ba883de15483ecfa8
Push with failures, failure log.

Flags: needinfo?(mconley)
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/62e4ad09e786
Use Proton checkboxes for in-content pages when Proton is enabled. r=Itiel,desktop-theme-reviewers
Flags: needinfo?(mconley)
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Blocks: 1703028
Blocks: 1703043
You need to log in before you can comment on or make changes to this bug.