Closed Bug 1700178 Opened 1 year ago Closed 1 year ago

Attempt to reduce stutter during full-screen menubar reveal animation

Categories

(Core :: Widget: Cocoa, task)

All
macOS
task

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox89 --- verified

People

(Reporter: mstange, Assigned: mstange)

References

Details

(Whiteboard: [mac:fullscreen])

Attachments

(1 file)

With the patch from bug 1699506, when the full screen revealAmount changes, we set a different CSS transform on the toolbox. This visual update is delayed by up to two vsync intervals: First, the main thread paint is delayed until the refresh driver ticks. Then the composite is delayed until the next vsync event.
If a CoreAnimation composition happens during this window on the main thread, our drawing will probably not be in sync with it. This can create a stutter effect.

Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/089f6c9bbcc9
Trigger a main thread repaint immediately when the revealAmount changed, to reduce stuttering during the animation. r=mac-reviewers,bradwerth
Summary: Attempt to reduce flickering during full-screen menubar reveal animation → Attempt to reduce stutter during full-screen menubar reveal animation
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Hello Markus! Are there any steps that manual QA can do to verify this issue? Thank you!

Flags: needinfo?(mstange.moz)

The fix was only intended to result in a minor, barely noticeable animation quality improvement. So the only QA that's needed here is to check that it didn't introduce new bugs.

However, Martin says that it may also have fixed the sliding animation 10.15. Can you confirm that?

Flags: needinfo?(mstange.moz)

Martin is correct! The sliding animation is smooth now on the latest Nightly 89.0a1 (20210324084848). We tested this on macOS 10.15, 10.14, 10.13, 10.12, and 11.2.3 M1 to be sure with native fullscreen enabled and disabled as well.
Can we close this as verified given the above? Thank you!

Blocks: 1699688

Sure!

Thank you! Closing this as verified per comment 7.

Status: RESOLVED → VERIFIED
Whiteboard: [mac:fullscreen]
You need to log in before you can comment on or make changes to this bug.