170019 - Sanity check for flags in right product.

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Matthew Tuck [:CodeMachine]]

Attachment statuses can get set on the wrong product.  We need a sanity check
for this.

Comment 1

[ylf75328]

Attachment: test

sorry  this is test for me

Comment 2

[Dave Miller [:justdave]]

Reassigning bugs that I'm not actively working on to the default component owner
in order to try to make some sanity out of my personal buglist.  This doesn't
mean the bug isn't being dealt with, just that I'm not the one doing it.  If you
are dealing with this bug, please assign it to yourself.

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

Comment 4

[Max Kanat-Alexander]

Comment on attachment 232746 [details] [diff] [review]
patch, v1

  Well, you're the Flags owner. So I assume your SQL is right and all that. :-)

>+my $invalid_flags = $dbh->selectall_arrayref(

  You could do {Slice=>{}} so that you don't have to do a mysterious ->[0] below.

>+$invalid_flags = $dbh->selectall_arrayref(
>+       'SELECT DISTINCT flags.id, flags.bug_id, flags.attach_id
>+          FROM flags

  Could you name this second variable differently so that we know how these invalid flags differ from the above invalid flags?

Comment 5

[Frédéric Buclin]

Checking in sanitycheck.cgi;
/cvsroot/mozilla/webtools/bugzilla/sanitycheck.cgi,v  <--  sanitycheck.cgi
new revision: 1.123; previous revision: 1.122
done