Sanity check for flags in right product.

RESOLVED FIXED in Bugzilla 3.0

Status

()

Bugzilla
Administration
--
enhancement
RESOLVED FIXED
16 years ago
12 years ago

People

(Reporter: CodeMachine, Assigned: Frédéric Buclin)

Tracking

unspecified
Bugzilla 3.0
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.62 KB, patch
Max Kanat-Alexander
: review+
Details | Diff | Splinter Review
(Reporter)

Description

16 years ago
Attachment statuses can get set on the wrong product.  We need a sanity check
for this.

Comment 1

15 years ago
Created attachment 119383 [details]
test 

sorry  this is test for me
Attachment #119383 - Attachment is obsolete: true
Summary: Sanity check for attachment status in right product. → Sanity check for flags in right product.
Reassigning bugs that I'm not actively working on to the default component owner
in order to try to make some sanity out of my personal buglist.  This doesn't
mean the bug isn't being dealt with, just that I'm not the one doing it.  If you
are dealing with this bug, please assign it to yourself.
Assignee: justdave → administration
QA Contact: mattyt-bugzilla → default-qa
(Assignee)

Updated

13 years ago
Assignee: administration → LpSolit
Depends on: 286160
Target Milestone: --- → Bugzilla 2.22
(Assignee)

Updated

13 years ago
Target Milestone: Bugzilla 2.22 → Bugzilla 2.24
(Assignee)

Comment 3

12 years ago
Created attachment 232746 [details] [diff] [review]
patch, v1
Attachment #232746 - Flags: review?(wicked+bz)
(Assignee)

Updated

12 years ago
Severity: normal → enhancement
Status: NEW → ASSIGNED

Comment 4

12 years ago
Comment on attachment 232746 [details] [diff] [review]
patch, v1

  Well, you're the Flags owner. So I assume your SQL is right and all that. :-)

>+my $invalid_flags = $dbh->selectall_arrayref(

  You could do {Slice=>{}} so that you don't have to do a mysterious ->[0] below.

>+$invalid_flags = $dbh->selectall_arrayref(
>+       'SELECT DISTINCT flags.id, flags.bug_id, flags.attach_id
>+          FROM flags

  Could you name this second variable differently so that we know how these invalid flags differ from the above invalid flags?
Attachment #232746 - Flags: review?(wicked+bz) → review+

Updated

12 years ago
Flags: approval?
Flags: approval? → approval+
(Assignee)

Comment 5

12 years ago
Checking in sanitycheck.cgi;
/cvsroot/mozilla/webtools/bugzilla/sanitycheck.cgi,v  <--  sanitycheck.cgi
new revision: 1.123; previous revision: 1.122
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.