Closed
Bug 170031
Opened 23 years ago
Closed 23 years ago
unparsed string in quicklaunch 'disable quicklaunch' dialog
Categories
(Core Graveyard :: QuickLaunch (AKA turbo mode), defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.2beta
People
(Reporter: eyalroz1, Assigned: mike_jk)
References
Details
Attachments
(1 file, 3 obsolete files)
|
1.23 KB,
patch
|
caillon
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
When right-clicking quicklaunch and selecting the disable entry, I get a dialog
saying: "Disabling Quick Launch will increase ... blah blah blah and check "Keep
&brandShortName; in memory to improve startup performance." Are you blah blah
blah..."
notice the &brandShortname; thing...
build: 2002092008
|
||
Comment 1•23 years ago
|
||
Mike, you broke this with the checkin for bug 158173
Assignee: law → pepperxn
Severity: trivial → major
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
Assignee | |
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.2beta
|
|
Assignee | |
Comment 2•23 years ago
|
||
*** Bug 170689 has been marked as a duplicate of this bug. ***
Attachment #100288 -
Attachment is obsolete: true
|
||
Comment 5•23 years ago
|
||
Comment on attachment 100648 [details] [diff] [review]
a valid but very confusing way to mix %s and %1$s
Confusing syntax. I'd almost rather we pass in another string, but this works
too.
Attachment #100648 -
Flags: review+
|
|
Assignee | |
Comment 6•23 years ago
|
||
Attachment #100648 -
Attachment is obsolete: true
|
|
||
Comment 7•23 years ago
|
||
Comment on attachment 100852 [details] [diff] [review]
same as attachment #100288 [details] [diff] [review] iow this doesn't work either
r=caillon :-)
Attachment #100852 -
Flags: review+
|
||
Comment 8•23 years ago
|
||
Sorry for confusing you on that last patch, caillon. Should be %1$S on both, of
course, since both should be "Mozilla" or "Netscape" or ... etc.
New patch coming up.
|
|
||
Comment 10•23 years ago
|
||
Comment on attachment 100856 [details] [diff] [review]
patch
sr=jag
Attachment #100856 -
Flags: superreview+
|
|
||
Comment 11•23 years ago
|
||
Comment on attachment 100856 [details] [diff] [review]
patch
hmm. :-) third time's a charm? r=caillon
Attachment #100856 -
Flags: review+
|
||
Comment 12•23 years ago
|
||
Comment on attachment 100852 [details] [diff] [review]
same as attachment #100288 [details] [diff] [review] iow this doesn't work either
just for reference
Attachment #100852 -
Attachment description: patch → same as attachment #100288 iow this doesn't work either
Attachment #100852 -
Flags: needs-work+
Attachment #100648 -
Attachment description: %s doesn't work that way → a valid but very confusing way to mix %s and %1$s
Attachment #100288 -
Attachment description: fix → doesn't work because there's only one parameter so the second thing results in empty
Attachment #100288 -
Flags: needs-work+
|
|
||
Comment 13•23 years ago
|
||
attachment 100856 [details] [diff] [review] checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Comment 14•23 years ago
|
||
verified on trunk builds - Mozilla 2002092704 and commercial 2002092704
Status: RESOLVED → VERIFIED
|
|
Assignee | |
Updated•23 years ago
|
Keywords: mozilla1.0.2
|
||
Updated•13 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•