1700351 - Mute/Unmute icon is visible on hover when PiP is enabled and the video is paused

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Negritas Sergiu, Desktop QA]

Attachment: favicon

Affected Versions:
*Nightly 89.0a1

Tested On:
*Windows 10
*Ubuntu 20.04
*Mac OS X 10.15

Steps to Reproduce:

1. Launch Firefox.
2. Go to a video sharing website (eg. www.youtube.com) and start a random video - with sound.
3. Click on PiP toggle.
4. Open a second tab on a video sharing website(eg. www.twitch.tv) and start a random video.
5. Click on PiP toggle.
6. Stop one video from the PiP screen.
7. After a few seconds hover over the tabs with the PiP icon.
8. Observe the mute/unmute icon from the tab.

Expected:
The mute/unmute icon shouldn't be displayed on hover over the tabs favicon.

Actual:
There is a white square in the position of the mute/unmute favicon inside the tab.

Notes:
Please see the attached screenshot.
This issue might be related to the fix on the bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1699677

Comment 1

[Negritas Sergiu, Desktop QA]

Hello!
I have done some updates on this issue and I would like to add that this issue also occurs with pinned tabs.
Jared could you please look and see if the patch added on the bug mentioned in the description is the culprit of this issue? And if not could you please let me know if I?

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1699677

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

I believe this was fixed by bug 1700989. Can you please retest?

Comment 4

[Negritas Sergiu, Desktop QA]

Hello Jared! I have just retested this issue and I can confirm that the initial issue is fixed. However there is a slight delay until the mute icon is not triggered anymore(about 2-5 seconds or less) after stopping the PIP video.
Should I file a new bug regarding the delay or leave this one opened?

Thank you!

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

This is intentional behavior. We don't want to remove the sound-playing icon immediately because we want to help users find what tab the sound was coming from in case it starts up again soon and the user wants to mute the tab.

I'll close this bug as fixed based on comment #4.

Comment 6

[Negritas Sergiu, Desktop QA]

Hello! Given the comment 4 and 5 I will mark this issue as verified. I also verified it today using Firefox 89.0a1(2021-04-06)

Thank you!