1700371 - Extremely low contrast on stoplight buttons when Firefox is light and system is dark

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Harry Twyford]

Attachment: Screen Shot 2021-03-23 at 10.59.00 AM.png

STR:

1. Set widget.macos.respect-system-appearance to true.
2. Set system theme to Dark.
3. Enable a light Firefox theme, such as Light, Proton Light, or Google Chrome Light.
4. Unfocus the Firefox window.

Actual results:
The stoplight buttons are white-on-white. Screenshot attached.

Expected: Dark grey stoplight buttons, like one sees when the system theme is Light.

I imagine this is because we're drawing the Dark mode stoplight buttons even when the Firefox theme is light.

Comment 1

[Markus Stange [:mstange]]

We can fix this by overriding the NSWindow appearance with "aqua" (light) or "dark aqua" (dark) based on the selected Firefox theme.
In order to do that, we need to communicate GetDocumentLWTheme() == Document::Doc_Theme_Bright to the nsIWidget. The code for that can be found in https://phabricator.services.mozilla.com/D104301 .

Comment 2

[Markus Stange [:mstange]]

I would suggest an nsIWidget method called SetWindowAppearance(WindowAppearance aAppearance); with enum class WindowAppearance : uint8_t { eSystem, eLight, eDark }.

Comment 3

[Stephen A Pohl [:spohl]]

Attachment: Bug 1700371: Override the NSWindow appearance based on the lightweight theme. r=mstange

Comment 4

[Stephen A Pohl [:spohl]]

Attachment: Bug 1700371: Update references for Mac OS X to macOS in nsIWidget.h. r=mstange

Depends on D109981

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e70f3af0e7f2
Improve contrast of close, minimize and maximize buttons on macOS with a light Firefox theme when the system is in dark mode. r=mac-reviewers,mstange
https://hg.mozilla.org/integration/autoland/rev/840762c09a0a
Update references for Mac OS X to macOS in nsIWidget.h. r=mstange

Comment 6

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1700371) as per dev's request

Backout:
https://hg.mozilla.org/integration/autoland/rev/42eb327519b3446b84e84f5ac7e93b8ee89689c5

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5f124d38938
Override the NSWindow appearance based on the lightweight theme. r=mac-reviewers,mstange
https://hg.mozilla.org/integration/autoland/rev/8599b8c86aaf
Update references for Mac OS X to macOS in nsIWidget.h. r=mstange

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a5f124d38938
https://hg.mozilla.org/mozilla-central/rev/8599b8c86aaf

Comment 9

[Bogdan Maris, Desktop QA]

Reproduced the initial issue using old Nightly from 2021-03-23 on macOS 11.3, verified that this is fixed using Firefox 89.0beta10 on the same configuration.