1700375 - Double-tap to zoom is not working on (some) textareas

Status: VERIFIED FIXED

(Core :: Panning and Zooming, defect)

Description

[Emil Ghitta, QA [:emilghitta]]

Affected versions

• Firefox 89.0a1 (BuildId:20210323094659)
• Firefox 88.0b1 is also affected but this feature is disabled by default on 88 beta builds.

Affected platforms

• macOS 10.14
• macOS 11.1

Unaffected platforms

• Windows 10 64bit
• Ubuntu 20.04

Steps to reproduce

1. Launch Firefox.
2. Access the following test case: data:text/html,%20 <textarea name="message" rows="10" cols="30">The cat was playing in the garden.</textarea>
3. Double-tap to zoom inside the textarea field.

Expected result

• The double-tap to zoom functionality is working on the textarea field (as in Safari).

Actual result

• The double-tap to zoom functionality is not working on the textarea field.

Regression Range

• I don’t think that this is a regression.

Notes

• For further information regarding this issue, please access this link for screencast.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1700375. Treat replaced elements as non-inline for the purposes of determining which element to zoom to for double tap to zoom. r?emilio

Bug 1539469 changed all inputs to inline-block based on the spec discussion https://github.com/whatwg/html/issues/4082 but textarea's were not part of that.

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1700375. Add test. r?emilio

Depends on D109574

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b974265bd38f
Treat replaced elements as non-inline for the purposes of determining which element to zoom to for double tap to zoom. r=emilio
https://hg.mozilla.org/integration/autoland/rev/48d10ca94fa6
Add test. r=emilio

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b974265bd38f
https://hg.mozilla.org/mozilla-central/rev/48d10ca94fa6

Comment 5

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 89.0a1 (BuildId:20210408095111) on macOS 10.15