Closed Bug 1700473 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 28196 - Switch ImageDecoder over to new ImageTrack semantics.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox89 fixed)

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28196 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28196
Details from upstream follow.

b'Dale Curtis <dalecurtis@chromium.org>' wrote:

Switch ImageDecoder over to new ImageTrack semantics.

This moves frameCount and repetitionCount onto the track properties
and removes selectTrack() in favor of "track.selected = true". The
tracks list is modeled after Audio/VideoTrackList, but for now does
not include any events.

This also hardens the 'animated' status on a track so that it won't
change after metadata has been retrieved. repetitionCount is switched
to a 'unrestricted float' so 'Infinity' can be be accurately signaled.

R=chcunningham

Bug: 1182435, 1183456
Test: New and updated unittests and wpt tests.
Change-Id: Ibf8363e6f80d998202d42f745180812953681da9
Reviewed-on: https://chromium-review.googlesource.com/2783220
WPT-Export-Revision: 7f6e12759e6ab1de7357c4590805550c48dd31bf

PR 28196 applied with additional changes from upstream: ac36875829b28066dc2268f94779ee75d9e903b0

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 21 subtests

Status Summary

Firefox

OK : 2
FAIL: 42

Chrome

OK : 2
PASS: 30
FAIL: 12

Safari

OK : 2
FAIL: 42

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webcodecs/image-decoder.any.html
Test JPEG image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation top-left.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation top-right.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation bottom-right.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation bottom-left.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation left-top.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation right-top.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation right-bottom.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation left-bottom.: FAIL (Chrome: PASS, Safari: FAIL)
Test PNG image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test AVIF image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test multi-track AVIF image decoding w/ preferAnimation=false.: FAIL (Chrome: FAIL, Safari: FAIL)
Test multi-track AVIF image decoding w/ preferAnimation=true.: FAIL (Chrome: FAIL, Safari: FAIL)
Test WEBP image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test GIF image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test invalid mime type rejects decode() requests: FAIL (Chrome: PASS, Safari: FAIL)
Test invalid mime type rejects decodeMetadata() requests: FAIL (Chrome: PASS, Safari: FAIL)
Test decode, decodeMetadata after no track selected.: FAIL (Chrome: FAIL, Safari: FAIL)
Test track selection in multi track image.: FAIL (Chrome: FAIL, Safari: FAIL)
Test ReadableStream of gif: FAIL (Chrome: FAIL, Safari: FAIL)
Test ReadableStream aborts promises on track change: FAIL (Chrome: FAIL, Safari: FAIL)
/webcodecs/image-decoder.any.worker.html
Test JPEG image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation top-left.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation top-right.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation bottom-right.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation bottom-left.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation left-top.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation right-top.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation right-bottom.: FAIL (Chrome: PASS, Safari: FAIL)
Test JPEG w/ EXIF orientation left-bottom.: FAIL (Chrome: PASS, Safari: FAIL)
Test PNG image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test AVIF image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test multi-track AVIF image decoding w/ preferAnimation=false.: FAIL (Chrome: FAIL, Safari: FAIL)
Test multi-track AVIF image decoding w/ preferAnimation=true.: FAIL (Chrome: FAIL, Safari: FAIL)
Test WEBP image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test GIF image decoding.: FAIL (Chrome: PASS, Safari: FAIL)
Test invalid mime type rejects decode() requests: FAIL (Chrome: PASS, Safari: FAIL)
Test invalid mime type rejects decodeMetadata() requests: FAIL (Chrome: PASS, Safari: FAIL)
Test decode, decodeMetadata after no track selected.: FAIL (Chrome: FAIL, Safari: FAIL)
Test track selection in multi track image.: FAIL (Chrome: FAIL, Safari: FAIL)
Test ReadableStream of gif: FAIL (Chrome: FAIL, Safari: FAIL)
Test ReadableStream aborts promises on track change: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f7e4a2bc4448 [wpt PR 28196] - Switch ImageDecoder over to new ImageTrack semantics., a=testonly https://hg.mozilla.org/integration/autoland/rev/e74bb0751d94 [wpt PR 28196] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f7e4a2bc4448
https://hg.mozilla.org/mozilla-central/rev/e74bb0751d94

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.