Closed Bug 1700509 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 28201 - Update offsetParent behavior in shadow trees

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28201 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28201
Details from upstream follow.

b'Joey Arhar <jarhar@chromium.org>' wrote:

Update offsetParent behavior in shadow trees

New behavior for offsetParent in shadow trees was discussed in [1] and
[2]. This lead to a chromium patch [3] which changed the behavior. After
[3] landed, the desired behavior in the discussions in [1] and [2]
seemed to have changed. Unfortunately, the author of [3] was no longer
working on chromium. This new behavior was then added to the spec and
landed in webkit [4] and firefox [5], and a WPT was added for it [6].

This patch implements the new behavior to follow suit with webkit and
firefox based on the WPT in [6]. Unfortunately, there are several tests
which are either internal to chromium or are only passing in chromium
which appear to oppose this new behavior and will have to be updated or
removed:

  • external/wpt/css/css-contain/content-visibility/content-visibility-035.html
  • external/wpt/css/css-contain/content-visibility/content-visibility-044.html
  • fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html
  • shadow-dom/offsetParent.html
    For shadow-dom/offsetParent.html, I verified that firefox and safari
    both currently fail the same tests which this patch does.

[1] https://github.com/WICG/webcomponents/issues/497
[2] https://github.com/w3c/csswg-drafts/issues/159
[3] https://chromium.googlesource.com/chromium/src/+/18d455ee833f6a30dcbe2755380861eb75cd9f6f
[4] https://trac.webkit.org/changeset/239313/webkit
[5] https://bugzilla.mozilla.org/show_bug.cgi?id=1514074
[6] https://wpt.fyi/results/shadow-dom/offsetParent-across-shadow-boundaries.html

Fixed: 920069
Change-Id: I168edc5ad0e4fcb92d0c4a440623f2424b14a988

Reviewed-on: https://chromium-review.googlesource.com/2775208
WPT-Export-Revision: cded7f838b41362736867ebb759a7c7f11bd2ea3

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
PASS : 1
FAIL : 1

Chrome

OK : 2
PASS : 2

Safari

OK : 1
FAIL : 1
TIMEOUT: 1
ERROR : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-contain/content-visibility/content-visibility-035.html
Testing focus and force layout on element with hidden flat-tree ancestor: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b03075225de2
[wpt PR 28201] - Update offsetParent behavior in shadow trees, a=testonly
https://hg.mozilla.org/integration/autoland/rev/6bb5bc0af069
[wpt PR 28201] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.