Closed Bug 1700590 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 28210 - WIP [TablesNG] scroll overflow fix

Categories

(Core :: Layout: Tables, task, P4)

Product:
Core
Component:
Layout: Tables
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28210 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28210
Details from upstream follow.

b'Aleks Totic <atotic@chromium.org>' wrote:

WIP [TablesNG] scroll overflow fix

The testcase demostrates the bug.
Tables with collapsed borders are not computing their
scroll overflow correctly.

I tried overriding ComputeLayoutOverflow in NGLayoutTable
but that did nothing, and never got called.
What am I missing?

Bug: 711360
Change-Id: I6231fbc549ae15f2c251e9392773c785b2b75b02

Reviewed-on: https://chromium-review.googlesource.com/2784440
WPT-Export-Revision: f20c04e05c3db4d6de7e3daf27ad6f793eb4f00c

Component: web-platform-tests → Layout: Tables
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-tables/collapsed-scroll-overflow.html
visual overflow is included in scroll area: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PASS [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub] (Chrome: FAIL, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f28e2dc14cfa
[wpt PR 28210] - [TablesNG] scroll overflow fix, a=testonly
https://hg.mozilla.org/integration/autoland/rev/4d0896d71727
[wpt PR 28210] - Update wpt metadata, a=testonly
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b017985ee85
[wpt PR 28210] - [TablesNG] scroll overflow fix, a=testonly
https://hg.mozilla.org/integration/autoland/rev/ef6361547e79
[wpt PR 28210] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bca2e52648ca
[wpt PR 28210] - [TablesNG] scroll overflow fix, a=testonly
https://hg.mozilla.org/integration/autoland/rev/08ee155f20f5
[wpt PR 28210] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a8c5d308f81c
[wpt PR 28210] - [TablesNG] scroll overflow fix, a=testonly
https://hg.mozilla.org/integration/autoland/rev/ee196e80e7bb
[wpt PR 28210] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a8c5d308f81c
https://hg.mozilla.org/mozilla-central/rev/ee196e80e7bb

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.