1700674 - Picture-in-picture window doesn't use native fullscreen even if full-screen-api.macos-native-full-screen is set

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Markus Stange [:mstange]]

Steps to reproduce:

1. Be on macOS, and set full-screen-api.macos-native-full-screen to true.
2. Go to a YouTube video.
3. Open the video in PiP mode.
4. Double-click the PiP window.

Expected results:
The video should be displayed in native fullscreen.

Actual results:
The video is displayed in non-native fullscreen.

Comment 1

[Kris Wright :KrisWright]

The problem seems to be happening right here, where we aren't getting a native fullscreen support. Because of this it displays in non-native fullscreen even though the pref is flipped.

Comment 2

[Kris Wright :KrisWright]

Attachment: Bug 1700674 - Add native full screen attribute to picture-in-picture r?Gijs

This adds the macos native fullscreen attribute to picture-in-picture windows so that when the pref is enabled, we view native fullscreen.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/709f48d5b837
Add native full screen attribute to picture-in-picture r=pip-reviewers,mhowell

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/709f48d5b837

Comment 5

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I managed to reproduce this issue on Firefox 102.0(build ID: 20220623063721) on macOS 11. Verified as fixed on Firefox 103.0b2(build ID: 20220628190840) and Nightly 104.0a1(build ID: 20220629215821) on macOS 11.