Closed Bug 1700677 Opened 3 years ago Closed 3 years ago

Perma css/css-fonts/ascent-descent-override.html, line-gap-override.html and wpt like fontface-override-descriptor-getter-setter.sub.html failures when Gecko 89 merges to Beta on 2021-04-19

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox86 --- unaffected
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 + verified

People

(Reporter: aryx, Assigned: aryx)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Bug 1700677 - set layout.css.font-metrics-overrides.enabled to let css-fonts test pass with Beta and Release. r=jfkthame DONTBUILD
48 bytes, text/x-phabricator-request
Details | Review

@font-face metrics override is only enabled in Nightly and controlled by the
preference layout.css.font-metrics-overrides.enabled (added in bug 1681691).

Summary: Perma css/css-fonts/ascent-descent-override.html and line-gap-override.html failures when Gecko 89 merges to Beta on 2021-04-19 → Perma css/css-fonts/ascent-descent-override.html, line-gap-override.html and wpt like fontface-override-descriptor-getter-setter.sub.html failures when Gecko 89 merges to Beta on 2021-04-19
Attachment #9211295 - Attachment description: Bug 1700677 - set css-fonts tests ascent-descent-override.html and line-gap-override.html as failing with Beta and Release. r=jfkthame DONTBUILD → Bug 1700677 - set css-fonts tests as failing with Beta and Release. r=jfkthame DONTBUILD

Rather than marking them as failing, I'd prefer to annotate the tests with the appropriate pref setting to ensure they still work. (Sorry, should've done that in the original bug, I guess.)

However, I'm intending to send an Intent to Ship for this fairly shortly, and then enable the pref for all channels, so the issue may go away anyhow - hopefully before merge date.

They are slated to ride the trains starting with this cycle (Gecko 89).

@font-face metrics override is only enabled in Nightly and controlled by the
preference layout.css.font-metrics-overrides.enabled (added in bug 1681691).

Attachment #9211295 - Attachment is obsolete: true
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/5ca4929169fa
set layout.css.font-metrics-overrides.enabled to let css-fonts test pass with Beta and Release. r=jfkthame DONTBUILD

https://hg.mozilla.org/mozilla-central/rev/5ca4929169fa

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox89: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: