Closed Bug 1700691 Opened 4 years ago Closed 4 years ago

Status bar of compose window too high (TB 78 only)

Categories

(Thunderbird :: Theme, defect)

defect

Tracking

(thunderbird_esr78 fixed, thunderbird88 unaffected, thunderbird89 unaffected)

RESOLVED FIXED
Thunderbird 78.0
Tracking Status
thunderbird_esr78 --- fixed
thunderbird88 --- unaffected
thunderbird89 --- unaffected

People

(Reporter: klaus.bartosch, Assigned: Paenglab)

Details

(Whiteboard: TB 78 only)

Attachments

(4 files)

The status bar of the compose window in TB 78 is four pixels higher that in TB 68. The good thing is that in TB 87 beta 3 it's only two pixels higher than in TB 68. I haven't tried a Daily.

In TB 78 and 87 the vertical delimiters don't connect to the horizontal lines.

Whatever made the status area smaller again should be backported to TB 78. Preferably the height should be returned to the height of TB 68 everywhere.

Actually, it's not only the compose window, for the main Windows I see this: TB 87 smallest, TB 68 one pixel higher, TB 78 another pixel higher, so two pixels higher than TB 87.

This is a TB 78 only issue.

TB 78 has still a min-height set of 24px for the toolbarbutton-1 and we need to change this instead of the height.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9211979 - Flags: review?(alessandro)

Thanks, with this change (applied in the inspector), the height of status bar shrinks by 2px, but it's still 1px higher than in TB 87 beta. Also, the issue of the vertical lines not connecting to the horizontal lines is also still present, even in TB 87.

The patch here apparently fixes an "78 only" issue, but even then, all version still have a status bar higher than TB 68 with disconnected separators. There's also an issue in the main window, see comment #1.

Summary: Status bar of compose window too high → Status bar of compose window and main window too high

The status bar can't shrink more because when you sign/encrypt the icon shown needs also space and would make the status bar jump in height.
The vertical bars don't use the full height to make the status bar look less blocky and also looking like the toolbar separators in the main

I see no difference between the status bars on main window between 78 and 87-89.

Attached image with progress.png

Well, if you're aiming for "less blocky", then you should apply this everywhere. The online/offline indicator (main window, bottom left) still uses the full height, as does the progress display (see screenshot).

For me, the status bar is 1px higher in TB 78. I just had the update to TB 88 beta. Anyway, no point arguing about one pixel. As you can see, in TB 88 there is one pixel padding under the "Today Panel" display, in TB 78 there are two.

Summary: Status bar of compose window and main window too high → Status bar of compose window too high
Summary: Status bar of compose window too high → Status bar of compose window too high (TB 78 only)
Comment on attachment 9211979 [details] [diff] [review] 1700691-languageStatusButton-height.patch Review of attachment 9211979 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks.
Attachment #9211979 - Flags: review?(alessandro) → review+

Comment on attachment 9211979 [details] [diff] [review]
1700691-languageStatusButton-height.patch

[Approval Request Comment]
User impact if declined: too high status bar in composer
Testing completed (on c-c, etc.): TB 78 only bug
Risk to taking this patch (and alternatives if risky): low

Flags: needinfo?(vseerror)
Attachment #9211979 - Flags: approval-comm-esr78?
Whiteboard: TB 78 only
Flags: needinfo?(vseerror)

Comment on attachment 9211979 [details] [diff] [review]
1700691-languageStatusButton-height.patch

[Triage Comment]
Approved for esr78

Attachment #9211979 - Flags: approval-comm-esr78? → approval-comm-esr78+
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 78.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: