1700700 - mach try pushes with --gecko-profile have broken vismet tasks

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P2)

Description

[Steve Fink [:sfink] [:s:]]

I did a push with --gecko-profile containing a vismet task that failed with

jsonschema.exceptions.ValidationError: 'gecko_profile' does not match '^[a-zA-Z0-9-]{1,24}$' 

Comment 1

[Steve Fink [:sfink] [:s:]]

It looks to me like this has been broken since bug 1631784 added "gecko_profile" to the extra_options in testing/raptor/raptor/results.py. The schema disallows underscores.

I don't know if the schema should be relaxed, or if the tag should be changed to what the schema seems to expect. I have a patch for the latter.

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1700700 - Rename gecko_profile -> gecko-profile in KNOWN_TEST_MODIFIERS/extra_options to satisfy schema validator

Comment 3

[Steve Fink [:sfink] [:s:]]

Given that this would need to change in 3 places, would it be better to add '_' to the schema?

Comment 4

[Greg Mierzwinski [:sparky]]

(In reply to Steve Fink [:sfink] [:s:] from comment #3)

Given that this would need to change in 3 places, would it be better to add '_' to the schema?

That sounds good to me, I'm fine with us modifying the tags schema to include _. We could also add : at the same time since there has been at least one case where we wanted to use that.

Comment 5

[Steve Fink [:sfink] [:s:]]

Er, I'm not sure why I made this be blocked by bug 1703717 just because testing this feature is how I found it. This is unrelated, except that if you try to use it then there's a good chance bug 1703717 will prevent you from getting a profile.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a53a86ee4b7
Rename gecko_profile -> gecko-profile in KNOWN_TEST_MODIFIERS/extra_options to satisfy schema validator r=perftest-reviewers,sparky

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0a53a86ee4b7