Open Bug 1700727 Opened 3 years ago Updated 2 years ago

Add some tests for native context menus

Categories

(Core :: Widget: Cocoa, task, P3)

All
macOS
task

Tracking

()

People

(Reporter: mstange, Unassigned)

References

Details

(Whiteboard: [proton-context-menus][mac:mr1])

We currently have tests for the native menu bar, and for nsStandaloneNativeMenu, and for non-native context menus. We do not yet have tests for native context menus. We should add some.

The following scenarios should be covered:

  • Opening and closing a menu programatically, and checking that all the correct events are fired. (popupshowing, popupshown, popuphiding, popuphidden)
  • Opening a menu and executing a menu item using -[NSMenu performActionForItemAtIndex:], and checking that the command event fires before the popuphiding event.
  • Changing the menuitem label while a menu is open (test for bug 1691553).
  • Destroying the menu DOM hierarchy at various points, e.g. during the popuphiding event, to make sure we don't crash.
Type: defect → task

Another one:

  • When a context menu is opened with a right mouse down event, the capturing content gets cleared (test for bug 1700706).
Priority: -- → P3

More:

  • During the popupshowing event, document.popupNode should be set to the popup's trigger node (test for bug 1700715).
  • During the command event, document.popupNode should be set to the popup's trigger node (test for bug 1701085).
  • If right-clicking outside of the menu reopens the same menu, make sure popuphiding/popuphidden fire before the contextmenu event (test for bug 1702041).
  • Non-native popups shouldn't be closed when a native context menu is opened on top of them (test for bug 1700710).
  • When setCommandNode was called before opening a native menu with a trigger content, make sure that document.popupNode is set back to null after the menu is closed (D110303).
No longer blocks: 1700679
You need to log in before you can comment on or make changes to this bug.