[wpt-sync] Sync PR 28222 - Add "popup" invoking attribute, and clean up ancestor walk
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 28222 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/28222
Details from upstream follow.
b'Mason Freed <masonf@chromium.org>' wrote:
Add "popup" invoking attribute, and clean up ancestor walk
With this CL, the "popup" attribute can be used on \<button> elements
only, to invoke a popup. Additional elements (e.g. \<input type=button>,
other input types, etc.) will be added in subsequent CLs. In addition,
this CL adds storage of all invoking elements on each \<popup>, so that
invokers can be checked in the ancestral popup walk. No code has been
added yet to populate this vector, since it is still up in the air [1]
whether this should be part of the behavior, and it is a bit
complicated to maintain this linkage.[1] https://github.com/MicrosoftEdge/MSEdgeExplainers/issues/463
Bug: 1168738
Change-Id: I62af6e7655ad67540082b5a796f8390e4a890f72
Reviewed-on: https://chromium-review.googlesource.com/2780636
WPT-Export-Revision: 68bca4384868edfe71443963c52b1dec708ac56c
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=45d05149378a7832a88f18a81fef8c77fafdc591
|
|
Assignee | |
Comment 2•3 years ago
|
||
CI Results
Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 3 tests and 4 subtests
Status Summary
Firefox
OK : 2
FAIL : 5
ERROR: 1
Chrome
OK : 3
PASS : 5
FAIL : 1
Safari
OK : 2
FAIL : 5
ERROR: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/html/semantics/interactive-elements/the-popup-element/popup-anchor-nesting.tentative.html: ERROR (Chrome: OK, Safari: ERROR)
/html/semantics/interactive-elements/the-popup-element/popup-invoking-attribute.tentative.html
Basic test of the 'popup' attribute on a button: FAIL (Chrome: FAIL, Safari: FAIL)
/html/semantics/interactive-elements/the-popup-element/popup-shadow-dom.tentative.html
Popups located inside shadow DOM can still be shown: FAIL (Chrome: PASS, Safari: FAIL)
anchor references do not cross shadow boundaries: FAIL (Chrome: PASS, Safari: FAIL)
anchor references use the DOM tree not the flat tree: FAIL (Chrome: PASS, Safari: FAIL)
The popup stack is preserved across shadow-inclusive ancestors: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/568558dfac7c [wpt PR 28222] - Add "popup" invoking attribute, and clean up ancestor walk, a=testonly https://hg.mozilla.org/integration/autoland/rev/00b334860468 [wpt PR 28222] - Update wpt metadata, a=testonly
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/57145ddfd157 [wpt PR 28222] - Add "popup" invoking attribute, and clean up ancestor walk, a=testonly https://hg.mozilla.org/integration/autoland/rev/422919e8fcf7 [wpt PR 28222] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e470e6d2351d [wpt PR 28222] - Add "popup" invoking attribute, and clean up ancestor walk, a=testonly https://hg.mozilla.org/integration/autoland/rev/b2edab23e467 [wpt PR 28222] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/33897f5c738a [wpt PR 28222] - Add "popup" invoking attribute, and clean up ancestor walk, a=testonly https://hg.mozilla.org/integration/autoland/rev/f72321d63f93 [wpt PR 28222] - Update wpt metadata, a=testonly
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/33897f5c738a
https://hg.mozilla.org/mozilla-central/rev/f72321d63f93
Description
•