Closed Bug 1700818 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 28232 - Revert "Reland "Roll WPT Tooling.""

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28232 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28232
Details from upstream follow.

b'Luke Zielinski <lpz@chromium.org>' wrote:

Revert "Reland "Roll WPT Tooling.""

This reverts commit 04b275defe5e2d5bd8c95ce529e2ced76c54ff06.

Reason for revert: Causing Android WPT tests to crash. Failure can
be found in this builder, https://ci.chromium.org/p/chromium/builders/ci/android-weblayer-pie-x86-wpt-fyi-rel/534. The crash stack is saying that a logger argument
is not being passed to maybe_parse_tombstone().

Original change's description:

Reland "Roll WPT Tooling."

This is a reland of bb3fab20f93691c54d347a2b9564d827d8a4d767

Key additions since the original CL (in PS3 and onward):

  • added //third_party/wpt_tools/wpt/tools/third_party/websockets, which
    is required by webdriver tests.
  • updated //chrome/test/chromedriver/test/run_webdriver_tests.py to
    import localpaths.py so it can use vendored-in deps (like websockets).
  • several updates to .vpython3 to add more wheels and bump up some
    versions.

Original change's description:

Roll WPT Tooling.

This is a significant change because we pull in the breaking py3-only
changes from upstream.

In addition to the changes made by //third_party/wpt_tools/checkout.sh,
this CL also includes several fixups to pass CQ (eg: some more py3
updates, and manually adding a webdriver bidi PR).

Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel
Change-Id: I6380ec6bb46fa6fe8e0db66ebe1f82122b5c3c87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2764543
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Rakib Hasan <rmhasan@google.com>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#863882}

Change-Id: I44674cdb767ade155a04fb5920bb339d066dce42
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2775239
Reviewed-by: Rakib Hasan <rmhasan@google.com>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Shengfa Lin <shengfa@google.com>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#866232}

Change-Id: I7ad8614d2a4ac7a2ca36fcf4584423a59454625e
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.