1700826 - Remove or update probes expiring in Firefox 90: BROWSER_ATTRIBUTION_ERRORS

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[telemetry-probes]

The following Firefox probes will expire in the next major Firefox nightly release: version 90 [1].

BROWSER_ATTRIBUTION_ERRORS

What to do about this:

1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #data-help Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[Tracking Requested - why for this release]:

This would cause test failures in browser/components/attribution/test/browser/browser_AttributionCode* if left unchanged.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Please push the patch for this bug this week. The version number will be increased next Monday.

Comment 3

[Andrei Oprea [:andreio]]

Hey I was looking at removing this probe but the tests seem to heavily rely on the telemetry pings to test all the failure edge cases. Would that be a good reason to keep it? Previously DS said it's not really useful.

Comment 4

[Shane Caraveo (:mixedpuppy)]

There is new work on AMO that will result in more use of attributions, so I think it's worth holding onto this to the end of the year. I'm checking in with product on that.

Comment 5

[Andrei Oprea [:andreio]]

I'll get a data review request to extend this, seems like the easiest fix.

Comment 6

[Andrei Oprea [:andreio]]

Attachment: Bug 1700826 - Extend data collection for BROWSER_ATTRIBUTION_ERRORS probe

Comment 7

[Andrei Oprea [:andreio]]

Attachment: data_review_1700826.txt

Comment 8

[Shane Caraveo (:mixedpuppy)]

Hi Andrei,
Now that I took a look at the patch that added these, my question would be whether there were any read errors associated with this ping. If no significant issue showed up, I'd just reverse the patch. However, I see that the mac support made use of this, so lets ping nalexander. In the meantime, r? for data review.

Comment 9

[Andrei Oprea [:andreio]]

This telemetry was added because the number of enrolled users was significantly lower than expected in some experiments targeting on attribution. Unfortunately by the time the probes made it to release we shifted our focus and experimented/enrolled other types of users and I don't think we ever took a good look at the data.
I am inclined to keep it because attribution data comes up often in various experiment designs.

Comment 10

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Comment on attachment 9215491 [details]
data_review_1700826.txt

1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes.

2. Is the data collection covered by the existing Firefox Privacy Notice?

Yes.

Comment 11

[Nick Alexander :nalexander [he/him]]

I am inclined to keep it because attribution data comes up often in various experiment designs.

Sorry to be slow clearing NI: I agree that we should extend this (and have r+ed the subsequent patch). When we want this data, we can't get it any other way.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/537ad28f6bb5
Extend data collection for BROWSER_ATTRIBUTION_ERRORS probe r=nalexander

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/537ad28f6bb5