Closed Bug 1700826 Opened 3 years ago Closed 3 years ago

Remove or update probes expiring in Firefox 90: BROWSER_ATTRIBUTION_ERRORS


(Firefox :: Messaging System, task, P1)




89 Branch
89.2 - Apr 5 - Apr 18
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 + fixed


(Reporter: telemetry-probes, Assigned: andreio)



(Whiteboard: [probe-expiry-alert])


(2 files)

The following Firefox probes will expire in the next major Firefox nightly release: version 90 [1].


What to do about this:

  1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
  2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #data-help Slack channel or the #telemetry Matrix room at We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team


This is an automated message sent from probe-scraper. See for details.

Assignee: nobody → andrei.br92
Severity: -- → S3
Iteration: --- → 89.1 - Mar 22 - Apr 4
Priority: -- → P1
Iteration: 89.1 - Mar 22 - Apr 4 → 89.2 - Apr 5 - Apr 18

[Tracking Requested - why for this release]:

This would cause test failures in browser/components/attribution/test/browser/browser_AttributionCode* if left unchanged.

Please push the patch for this bug this week. The version number will be increased next Monday.

Flags: needinfo?(andrei.br92)

Hey I was looking at removing this probe but the tests seem to heavily rely on the telemetry pings to test all the failure edge cases. Would that be a good reason to keep it? Previously DS said it's not really useful.

Flags: needinfo?(andrei.br92) → needinfo?(mixedpuppy)

There is new work on AMO that will result in more use of attributions, so I think it's worth holding onto this to the end of the year. I'm checking in with product on that.

I'll get a data review request to extend this, seems like the easiest fix.

Hi Andrei,
Now that I took a look at the patch that added these, my question would be whether there were any read errors associated with this ping. If no significant issue showed up, I'd just reverse the patch. However, I see that the mac support made use of this, so lets ping nalexander. In the meantime, r? for data review.

Flags: needinfo?(mixedpuppy) → needinfo?(nalexander)

This telemetry was added because the number of enrolled users was significantly lower than expected in some experiments targeting on attribution. Unfortunately by the time the probes made it to release we shifted our focus and experimented/enrolled other types of users and I don't think we ever took a good look at the data.
I am inclined to keep it because attribution data comes up often in various experiment designs.

Attachment #9215491 - Flags: data-review?(tdsmith)

Comment on attachment 9215491 [details]

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?


  1. Is the data collection covered by the existing Firefox Privacy Notice?


Attachment #9215491 - Flags: data-review?(tdsmith) → data-review+

I am inclined to keep it because attribution data comes up often in various experiment designs.

Sorry to be slow clearing NI: I agree that we should extend this (and have r+ed the subsequent patch). When we want this data, we can't get it any other way.

Flags: needinfo?(nalexander)
Pushed by
Extend data collection for BROWSER_ATTRIBUTION_ERRORS probe r=nalexander
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.