1700836 - Remove or update probes expiring in Firefox 90: firstStartup.*

Status: RESOLVED FIXED

(Toolkit :: General, task)

Description

[telemetry-probes]

The following Firefox probes will expire in the next major Firefox nightly release: version 90 [1].

firstStartup.statusCode
firstStartup.elapsed

What to do about this:

1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #data-help Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[Tracking Requested - why for this release]:

This needs to be taken care of before the version increase as the expiration will cause a test failure in toolkit/modules/tests/xpcshell/test_firstStartup.js

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Dave, can you assist with this? Rob is focused on Ion these days.

Comment 3

[Dave Townsend [:mossop]]

Adam? This looks installer related.

Comment 4

[Robert Helmer [:rhelmer]]

Mythmon, Rehan, are we still using the FirstStartup service for experiments? If so do you have strong feelings about keeping this probe or not?

Comment 5

[Michael Cooper [:mythmon]]

I'd like to keep FirstStartup service as a capability of experiments for now. I don't think we need to keep the probe though.

Comment 6

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

This doesn't look installer-related afaict. I don't think I know enough just now be comfortable just backing out bug 1582608 to remove the probes. Sorry to pass the buck back.

:dthayer are we interested in this timing from a startup perspective?

Comment 7

[Alex Thayer [:alexical] (she/her)]

I don't personally engage with it or know of anyone looking at it, so I'd be fine with the probes being removed.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1700836 - disable test_firstStartup.js because telemetry probe used expires in Gecko 90. a=prevent-permanent-test-failure

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/4abaacacabac
disable test_firstStartup.js because telemetry probe used expires in Gecko 90. a=prevent-permanent-test-failure

Comment 10

[Julien Cristau [:jcristau]]

(In reply to Adam Gashlin (he/him) [:agashlin] from comment #6)

This doesn't look installer-related afaict. I don't think I know enough just now be comfortable just backing out bug 1582608 to remove the probes. Sorry to pass the buck back.

Are we ready to do that now?

Comment 11

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

(In reply to Julien Cristau [:jcristau] from comment #10)

(In reply to Adam Gashlin (he/him) [:agashlin] from comment #6)

This doesn't look installer-related afaict. I don't think I know enough just now be comfortable just backing out bug 1582608 to remove the probes. Sorry to pass the buck back.

Are we ready to do that now?

I looked at it again and it isn't quite that simple, there's also bug 1576507. This still isn't really my area but I'll put up a patch.

Comment 12

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Attachment: Bug 1700836 - Remove expired firstStartup telemetry. r?mythmon!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/099906bf5f74
Remove expired firstStartup telemetry. r=mythmon

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/099906bf5f74

Comment 15

[Julien Cristau [:jcristau]]

Thanks Adam!

Comment 16

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

:aryx, I think we can mark this "wontfix" for 89 since you disabled the test in comment 9 before the version switch. I don't see any value in uplifting either of these patches. I'm not familiar with the protocol for changing these flags, if I can just flip it myself let me know.