1700897 - A row of space is missing between the title and the summary of the imported/not imported logins from the “Import Complete” modal

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: aRowSpaceIsMissing_ImportComepleteModal.PNG

[Affected versions]:

• Firefox Nightly 89.0a1 (Build ID: 20210322174641)
• Firefox Beta 88.0b2 (Build ID: 20210324160546)

[Affected Platforms]:

• Mac 11.2.3
• Windows 10 x64
• Ubuntu 20.04 x64

[Prerequisites]:

• Have the latest version of Firefox Nightly installed.
• Have saved on your computer a CSV file that contains only valid logins.

[Steps to reproduce]:

1. Open the Firefox browser.
2. Navigate to the "about:logins" page.
3. Click on the Menu button.
4. Select the “Import from a File…” option.
5. Select the CSV file from prerequisites and click on the “Open” button from the “Import Logins File” picker.
6. Observe the center part of the “Import Complete” modal.

[Expected result]:

• The spacing between the “Import Complete” title and the summary of the imported/not imported logins is larger.

[Actual result]:

• The spacing between the “Import Complete” title and the summary of the imported/not imported logins is not large enough.

[Notes]:

• Based on the mock-ups the spacing between the “Import Complete” title and the summary of the imported/not imported logins should be larger by one more row.
• Attached a screenshot with the issue.

Comment 1

[u689277]

Attachment: Bug 1700897 - Apply margin-top to generic dialog in aboutlogins.css r?tgiles

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/024c2d9e7194
Apply margin-top to generic dialog in aboutlogins.css r=tgiles

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/024c2d9e7194

Comment 4

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Firefox Nightly 94.0a1 (Build ID: 20210915152638) on Windows 10 x64, Mac 11.5.1, Ubuntu 20.04 x64.

• The spacing between the “Import Complete” title and the summary of the imported/not imported logins is larger.