1700930 - The text of the french "Import Complete" modal in “about:logins” displays the text for 1 login/error when there are 0 in text form instead of numbers

Status: VERIFIED FIXED

(Mozilla Localizations :: fr / French, defect)

Description

[Maria Heres, inactive, contact Ecosystem QA]

Attachment: fr vs en for 0 .png

[Affected Versions]:

• Firefox Beta 88.0b2 (Build ID: 20210323190052)
• Firefox Nightly 89.0a1 (Build ID: 20210324084848)

[Affected Platforms]:

• Windows 10
• Linux Mint 20
• macOS 10.15

[Prerequisites]:

• Have Firefox FR open.
• Have a CSV file that contains 0 logins and 0 errors.

[Steps to reproduce]:

1. Navigate to “about:logins”.
2. Click the meatball menu button (“...”).
3. Choose “Importer depuis un fichier…”
4. Select the CSV file from prerequisites and click on the "Importer" button.
5. Observe the text of modal that is displayed.

[Expected result]:

• The text displays the number of logins and errors as a number, not just text.
• The text correctly represents the number of logins and errors found as 0.

[Actual result]:

• The number of logins/errors is represented as text only.
• The text for 1 login/error is displayed even in the cases where there are 0.

[Notes]:

• Attached are screenshots of the issue and the expected form of the modal for 1 login/error in English.

Comment 1

[Francesco Lodolo [:flod]]

Théo, could you take a look?
https://transvision.mozfr.org/?recherche=about-logins-import-dialog-items&repo=gecko_strings&sourcelocale=en-US&locale=fr&search_type=strings_entities

The translation is wrong for 0, since the "one" case has "une" hard-coded.

In general I don't think localization should completely change the structure of a dialog. Right now, the information is quite harder to parse for French users.

Comment 2

[Théo Chevalier]

Thanks! Should be fixed with https://hg.mozilla.org/l10n-central/fr/rev/72c2bd66c9f2f78cc263f42eb4a37077da215a6b

Comment 3

[Maria Heres, inactive, contact Ecosystem QA]

We have verified that the issue is no longer reproducible on Firefox Beta FR 88.0b3 (Build ID: 20210325185929) and Firefox Nightly FR 89.0a1 (Build ID: 20210325161138) using Windows 10, Linux Mint 20 and macOS 10.15. The modal now uses both text and numbers to represent the number of login/errors and 0 is correctly represented. As a result I am closing this as verified fixed.