Closed Bug 1700948 Opened 3 years ago Closed 3 years ago

Also run all wasm tests explicitly with `--wasm-compiler=ion`

Categories

(Core :: JavaScript: WebAssembly, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: jseward, Assigned: jseward)

References

Details

Attachments

(1 file)

Now that we have Ion support for wasm on all Tier-1 targets, it's important to
ensure that wasm tests are always run on Ion. That's won't necessarily happen
in the situation that wasm via Cranelift is also supported in the build,
because optimising wasm compilation might be routed via Cranelift instead.
Hence, to guarantee test coverage of Ion, we need to add
test-also=--wasm-compiler=ion to all of the directives.txt files in
jit-test/tests/wasm.

Depends on: 1700900

Now that we have Ion support for wasm on all Tier-1 targets, it's important to
ensure that wasm tests are always run on Ion. That won't necessarily happen
in the situation that wasm via Cranelift is also supported in the build,
because optimising wasm compilation might be routed via Cranelift instead.
Hence, to guarantee test coverage of Ion, we need to add
test-also=--wasm-compiler=ion to all of the directives.txt files in
jit-test/tests/wasm.

Depends on D109860

Assignee: nobody → jseward
Status: NEW → ASSIGNED
Pushed by jseward@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ec85768e9b1
Also run all wasm tests explicitly with `--wasm-compiler=ion`.  r=lth.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: