Add |aFocus| parameter to <tabbrowser>::addTab

RESOLVED EXPIRED

Status

SeaMonkey
Tabbed Browser
RESOLVED EXPIRED
16 years ago
8 years ago

People

(Reporter: //, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

16 years ago
In:
xpfe/browser/resources/content/navigator.js
Use always BrowserOpenTab() for opening new tabs. This function already
exists, but no one use it in navigator.js. It is onyl used in:
http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/content/navigator.xul#398

Also, I added 2 parameters for making the function fits all situations while
conserving the original behavior.
(Reporter)

Comment 1

16 years ago
Created attachment 100109 [details] [diff] [review]
browser-open-tab.patch

This is the patch againts 1.2a navigator.js
Oliver, I suggest mailing jaggernaut@netscape.com and asking for review of that
patch....
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: patch, review
OS: Windows XP → All
Hardware: PC → All
(Reporter)

Comment 3

16 years ago
Hi Boris,
thanks, will do it.
I has made this patch while I was working on the patch for bug #37867,
then I talked to doron in #mozillazine and he suggested this idea.
Then, I separated this patch from the original one in bug #37867
and it worked.
QA Contact: sairuh → pmac
(Reporter)

Comment 4

16 years ago
Created attachment 103547 [details] [diff] [review]
browser-open-tab-12b.patch

- Updated to Mozilla 1.2b
- replaced all instances of .addTab() with BrowserOpenTab()
Attachment #100109 - Attachment is obsolete: true

Comment 5

16 years ago
You're making things more complex than they need to be. I have been thinking
about adding a second parameter to tabbrowser's addTab which specifies whether
to focus the tab or not. I would make undefined do the same as false so that you
only have to add true for those few places that need it.
Summary: Use always BrowserOpenTab() in navigator.js for opening new tabs → Add |aFocus| parameter to <tabbrowser>::addTab

Comment 6

16 years ago
Just to be clear, I don't see a need (at the moment) to make everything call
into BrowserAddTab instead of directly calling gBrowser.addTab. In fact, after
addTab has that second parameter added I would probably remove that function,
and make whatever takes us into and out of print preview mode set/remove
disabled="true" on cmd_newNavigatorTab instead of checking gInPrintPreviewMode.
(Reporter)

Comment 7

16 years ago
Ok, understand.
I was talking with doron on #mozillazine about a patch I made for bug #37867
and he sugested that I made a patch about BrowserAddTab().
If you already have the focus issue implemented in addTab(), I think we
can just close this bug.

Comment 8

16 years ago
It doesn't have it yet but it shouldn't be too hard to add.
(Assignee)

Updated

10 years ago
Product: Core → SeaMonkey
Assignee: jag → nobody
QA Contact: pmac → tabbed-browser

Comment 9

9 years ago
MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614
Status: NEW → UNCONFIRMED

Comment 10

9 years ago
MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 11

9 years ago
MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 12

8 years ago
MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420
Status: UNCONFIRMED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → EXPIRED
You need to log in before you can comment on or make changes to this bug.