1701032 - slashdot favicon not appearing in bookmarks toolbar

Status: VERIFIED FIXED

(Web Compatibility :: Site Reports, defect, P3)

Description

[mandarke]

Attachment: slashdot.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:86.0) Gecko/20100101 Firefox/86.0

Steps to reproduce:

navigated to https://slashdot.org/ via search engine result.

clicked and dragged https://slashdot.org/ tab to the bookmarks toolbar.

Actual results:

bookmark added with favicon that looks like a netball.

Expected results:

favicon created on bookmarks toolbar should be the same as the one on the tab.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Marco Bonardo [:mak]]

This is because they have a body tag in the middle of the head tag with some AdBlock Check stuff. that causes pageshow to happen before the icon, and we don't store favicons defined after pageshow, because often they are used to show badges or status updates.
It's a bug on slashdot, imo.

Comment 3

[mandarke]

(In reply to Marco Bonardo [:mak] from comment #2)

This is because they have a body tag in the middle of the head tag with some AdBlock Check stuff. that causes pageshow to happen before the icon, and we don't store favicons defined after pageshow, because often they are used to show badges or status updates.
It's a bug on slashdot, imo.

is there a way i can manually add the icon [https://slashdot.org/favicon.ico]?

Comment 4

[Marco Bonardo [:mak]]

I'm not aware of a simple way to do that, one could write a page script that injects the icon when the page loads, an add-on could do that.
The simplest thing would be to send them an email and let them know their html code is broken.

Comment 5

[lgenung]

(In reply to Marco Bonardo [:mak] from comment #2)

This is because they have a body tag in the middle of the head tag with some AdBlock Check stuff. that causes pageshow to happen before the icon, and we don't store favicons defined after pageshow, because often they are used to show badges or status updates.
It's a bug on slashdot, imo.

Just from a UX perspective, I'm left wondering why the page tab shows the favicon correctly, but I can't get the bookmark to ever save/load the favicon. It might make sense technically, due to storage protocol you describe. But it doesn't make much sense to me as a user.

Just my 2 cents.

Comment 6

[Marco Bonardo [:mak]]

Of course this is confusing for the user, but if we start inserting in the product hundreds of workarounds for server side issues, it becomes a mess to maintain. There must be a compromise, where only critical compatibility concerns are addressed with specific workarounds, that's for example the case for some -webkit css extensions. This case it just not common or problematic enough to deserve a workaround, rather than fixing the website to not be broken.

Comment 7

[Karl Dubost💡 :karlcow]

Needs Triage.

Comment 8

[Oana Arbuzov [:oanaarbuzov]]

The issue is still reproducible.
https://i.imgur.com/2HeeaH3.png

Tested with:
Browser / Version: Firefox Nightly 92.0a1 (2021-07-20)
Operating System: Ubuntu 20.04.2

Comment 9

[mandarke]

(In reply to Oana Arbuzov [:oanaarbuzov] from comment #8)

The issue is still reproducible.
https://i.imgur.com/2HeeaH3.png

Tested with:
Browser / Version: Firefox Nightly 92.0a1 (2021-07-20)
Operating System: Ubuntu 20.04.2

still reproducible in 91.0 running on ubuntu 20.04.2 LTS (Focal Fossa) 64-bit

Comment 10

[Oana Arbuzov [:oanaarbuzov]]

I was able to reproduce the issue, but after refreshing the page, the favicon loads correctly.
https://i.imgur.com/1M8z5c2.png

On Chrome the favicon is displayed correctly after being dragged to the "Bookmarks" bar.

Tested with:
Browser / Version: Firefox Nightly 104.0a1 (2022-06-27)
Operating System: Ubuntu 20.04.2, Windows 10 Pro

Mandarke are you getting the same behavior?

Comment 11

[mandarke]

(In reply to Oana Arbuzov [:oanaarbuzov] from comment #10)

I was able to reproduce the issue, but after refreshing the page, the favicon loads correctly.
https://i.imgur.com/1M8z5c2.png

On Chrome the favicon is displayed correctly after being dragged to the "Bookmarks" bar.

Tested with:
Browser / Version: Firefox Nightly 104.0a1 (2022-06-27)
Operating System: Ubuntu 20.04.2, Windows 10 Pro

Mandarke are you getting the same behavior?

i switched to windows and google chrome last September so haven't really gave it much thought. unless something changed in the current stable version i can get the favicon to show up by clicking and dragging the lock icon on the address bar the same time firefox loads the page. it's not consistent though.

Comment 12

[Oana Arbuzov [:oanaarbuzov]]

Thanks mandarke.
Probably this still needs a bit of work, for the favicon to be displayed automatically after being dragged to "Bookmarks" bar.

Comment 13

[mandarke]

(In reply to Oana Arbuzov [:oanaarbuzov] from comment #12)

Thanks mandarke.
Probably this still needs a bit of work, for the favicon to be displayed automatically after being dragged to "Bookmarks" bar.

i deleted the favicons.sqlite file, restarted then clicked the slashdot entry - no slashdot favicon showed showed up. i tried what you suggested by refreshing the page - still no slashdot favicon. tried again several times by pressing f5, ctrl-r, ctrl-shift-r, ctrl-click on bookmark. nothing.

how difficult will it be to add a "favicon location" to the edit bookmark option so i can paste in https://slashdot.org/favicon.ico ? obviously this would be for all websites, etc.

Comment 14

[Calin Tanase (PTO until 15th of May)]

This is still an issue on Firefox.

Tested on:
Operating system: Ubuntu 22.04 LTS
Browser/version: Nightly 111.0a1 (2023-02-02) / Chrome 109.0.5414.119

Comment 15

[mandarke]

(In reply to Calin Tanase from comment #14)

This is still an issue on Firefox.

Tested on:
Operating system: Ubuntu 22.04 LTS
Browser/version: Nightly 111.0a1 (2023-02-02) / Chrome 109.0.5414.119

yup.

tested on:

Name Firefox
Version 113.0.2
Build ID 20230522134052
OS Windows_NT 10.0 19045

Comment 16

[mandarke]

a workaround is to import a bookmark dump from chrome. not ideal but does the job.

Comment 17

[Marco Bonardo [:mak]]

I can confirm the page html is still unsupported, there is a <body> tag and later <link rel="shortcut icon" href="/favicon.ico" type="image/x-icon">

Now, I just noticed this is a root icon, we could likely add an exception just for these, as it's unlikely a site would use a root icon to show page status. Let me file a bug and get some opinions around that.

Comment 18

[Marco Bonardo [:mak]]

We landed a workaround in bug 1950815, so while the site html is still unordered, it will work from Firefox 137 on.

Comment 19

[Raul Bucata (⛔PTO until May 20🌴)]

The issue is fixed following the steps to reproduce

Tested with:

Browser / Version: Firefox Nightly 138.0a1 (2025-03-23) (64-bit)
Operating System: Windows 10 PRO x64

Comment 20

[Raul Bucata (⛔PTO until May 20🌴)]

Attachment: fixed issues on Firefox Nightly

Comment 21

[railioaie]

Verified, works as expected.

Tested with:

Browser / Version: Firefox 137.0-candidate build 1
Operating System: Windows 10