1701063 - moz-phab submit --reviewer didn't actually set reviewer

Status: RESOLVED DUPLICATE of bug 1501077

(Conduit :: moz-phab, defect)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: moz-phab-log

I have a big stack of patches on Bug 1662559 that I have commandeered from an ex-Mozillian. When I commandeered the revisions, I was labelled reviewer, and so the previous author (jorendorff) became reviewer. However, given he's not going to be around, I relabelled the patches locally to request review from arai.

However, it seems that something has gone wrong. When I submitted the stack, I remember it saying it would request review, and some of the low patches in the stack did in fact get updated to arai as reviewer.

However, it didn't take for all 20, as I realized today. So I re-submitted patches 4-20 expecting that I'd see arai set as reviewer. No such luck.

So I resubmitted again, with --reviewer arai... still nothing.

Attached is a trace from a third try, with --reviewer arai. As an arbitrary example, https://phabricator.services.mozilla.com/D108295 is at the moment of filing a bug still set to jorendorff as reviewer.

But If I look in the moz-phab submit log, I see the tool -is- aware I'm asking for Arai to get review:

Updating revision D108295:
INFO     2021-03-25 13:13:18,430 647343:f818d3c5e423 Bug 1662559 - Part 11: Move .privateBrand to a fixed location and add BytecodeEmitter::lookupPrivate() to find it. r=arai
DEBUG    2021-03-25 13:13:18,430 $ hg update --quiet f818d3c5e42357a2bbd0286c98a450820f7da5f6 --pager never
DEBUG    2021-03-25 13:13:19,636 --- arc message
Bug 1662559 - Part 11: Move .privateBrand to a fixed location and add BytecodeEmitter::lookupPrivate() to find it. r=arai

Summary:

Depends on D108294

Differential Revision: https://phabricator.services.mozilla.com/D108295

Depends on D108294

Test Plan:

Reviewers: arai

Subscribers:

Bug #: 1662559
---
DEBUG    2021-03-25 13:13:19,636 $ hg log -T '{node}' -r 'parents(f818d3c5e42357a2bbd0286c98a450820f7da5f6)' --pager never
DEBUG    2021-03-25 13:13:19,693 34af971d401aab6be96c14bf301eb7a63dc0ac13
DEBUG    2021-03-25 13:13:19,693 $ hg status --change f818d3c5e42357a2bbd0286c98a450820f7da5f6 --copies --pager never
DEBUG    2021-03-25 13:13:19,718 M js/src/frontend/BytecodeEmitter.cpp

Yet... nothing happens.

At this point I'm going to go change the reviewers manually.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: moz-phab-log-single-rev

Trying to submit just the single revision (Part 11 linked above) and nothing changes again: 

`moz-phab submit --trace --reviewer arai 647343:f818d3c5e423 647343:f818d3c5e423 2>&1 | tee moz-phab-log-single-rev`

```
WARNING  2021-03-25 13:28:02,413 No changes to submit.
```

Comment 2

[:glob ✱]

The crux of the problem is reviewers can be set both via the commit description and via phabricator; at the time Bug 1501077 was filed the path ahead wasn't clear due to the newness of Phabricator and moz-phab. I think it's clearer today what expectations are, will comment on that bug.