1701089 - vp09 codec string fails when parsing Widevine manifest

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Per https://source.chromium.org/chromium/chromium/src/+/master:components/cdm/common/cdm_manifest.cc;l=74;drc=775880ced8a989191281e93854c7f2201f25068f

Chrome have switched to the string "vp09" in their manifest format. We need to update our parser to accept this.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1701089 - Accept "vp09" codec string in Widevine manifest. r?alwu

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87c04ddb3dde
Accept "vp09" codec string in Widevine manifest. r=mjf

Comment 3

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

[Tracking Requested - why for this release]:

This issue is fatal to loading recent Widevine release -- Gecko will not load the CDM if it fails to parse the manifest. Given the looming release we should consider uplifts to avoid compatibility issues.

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/87c04ddb3dde

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:bryce, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

I plan to request uplift after performing a round of manual testing on nightly. Holding NI.

Comment 7

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 9211633 [details]
Bug 1701089 - Accept "vp09" codec string in Widevine manifest. r?alwu

Beta/Release Uplift Approval Request

• User impact if declined: Playback of DRM video will fail as we will not load the Widevine CDM.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: I have a PI request for the new CDM feature, this will be covered as part of that. I have also manually verified the patch functions as expected.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is low risk as this is a small change that is limited in scope and well understood. It makes our handling strictly more permissive, so we will not encounter issues such as rejecting manifest we used to accept -- but we will accept some we currently fail to parse.
• String changes made/needed: None.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed to handle new Widevine CDMs and continue to support DRM playback.
• User impact if declined: Playback of DRM video will fail as we will not load the Widevine CDM.
• Fix Landed on Version: 89.0a1
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is low risk as this is a small change that is limited in scope and well understood. It makes our handling strictly more permissive, so we will not encounter issues such as rejecting manifest we used to accept -- but we will accept some we currently fail to parse.
• String or UUID changes made by this patch: None.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9211633 [details]
Bug 1701089 - Accept "vp09" codec string in Widevine manifest. r?alwu

Approved for 88.0b5.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4f963460bce9

Comment 10

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 9211633 [details]
Bug 1701089 - Accept "vp09" codec string in Widevine manifest. r?alwu

Beta/Release Uplift Approval Request

• User impact if declined: Playback of DRM video will fail as we will not load the Widevine CDM. Because of the short time frame for the upcoming release it would be good to cover 87 while in release as we would like to target it with the new CDM. This would also help by giving us extra buffer for users who are slower to update from 87 to 88 once 88 rolls over. Users on the old CDM during that cycle are likely to see lower video quality being served, at worst some cites may cease to serve media to the old CDM all together.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is low risk as this is a small change that is limited in scope and well understood. It makes our handling strictly more permissive, so we will not encounter issues such as rejecting manifest we used to accept -- but we will accept some we currently fail to parse.
• String changes made/needed: None.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9211633 [details]
Bug 1701089 - Accept "vp09" codec string in Widevine manifest. r?alwu

Approved for 78.10esr. We may want to keep this on the radar as a ride-along if we end up needing a 78.9.1esr release as well.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/f1e9588ebd82

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9211633 [details]
Bug 1701089 - Accept "vp09" codec string in Widevine manifest. r?alwu

88 is in RC now and there are no plans for an 87 dot release.