1701094 - [wpt-sync] Sync PR 28252 - URLPattern: Revamp baseURL second argument approach.

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 28252 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28252
Details from upstream follow.

b'Ben Kelly <[e-mail]>' wrote:

URLPattern: Revamp baseURL second argument approach.

This CL revamps our approach to using a second argument for baseURL.
The changes include:

• Using a union type in the webidl so we can throw an informative
  exception instead of silently coercing an object to a string that
  always fails.
• Exposing the original input values in URLPatternResult.inputs. The
  old input property is now accessed as inputs[0].
• WPT test harness uses inputs to determine what to pass to test()
  and exec(). This replaces the old input and inputBaseURL
  properties.
• WPT test harness automatically validates the result inputs matches
  the argument inputs. Many duplicative input lines are removed
  as they are no longer needed.
• WPT test allows expected_match: 'error' to indicate that test()
  and exec() are expected to throw TypeError exceptions.
• WPT test removes error: true in favor of expected_obj: 'error' in
  order to match the behavior above for match errors.

Bug: 1141510
Change-Id: I3574393a965678595dd67d59931f9ec72338f346

Reviewed-on: https://chromium-review.googlesource.com/2785414
WPT-Export-Revision: 4cc1cbf4cbada3aa2ed142fe93c3d00dd9bff010

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 28252 applied with additional changes from upstream: 7508c0db81216e57d0856aaf3ae5d36562313b3c, 0d7dd845ec0c0482cbd8c11bddafe9878dc32522

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d04de371f7d197d61ea2003266b8db8bb9f0798

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 190 subtests

## Status Summary

### Firefox
OK   : 4
PASS : 4
FAIL : 756

### Chrome
OK   : 4
PASS : 304
FAIL : 456

### Safari
OK   : 3
PASS : 3
FAIL : 567
ERROR: 1

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d04de371f7d197d61ea2003266b8db8bb9f0798)
[GitHub PR Head](https://wpt.fyi/results/?sha=c6b4506492d534eb8674703dba41ef897c8a4cf2&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=c6b4506492d534eb8674703dba41ef897c8a4cf2&label=pr_base)

## Details

(See attachment for full changes)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d4afd270acc
[wpt PR 28252] - URLPattern: Revamp baseURL second argument approach., a=testonly
https://hg.mozilla.org/integration/autoland/rev/963172f070b5
[wpt PR 28252] - Update wpt metadata, a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e043daa21152
[wpt PR 28252] - URLPattern: Revamp baseURL second argument approach., a=testonly
https://hg.mozilla.org/integration/autoland/rev/a9461df0c80b
[wpt PR 28252] - Update wpt metadata, a=testonly

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35221cbd7f9b
[wpt PR 28252] - URLPattern: Revamp baseURL second argument approach., a=testonly
https://hg.mozilla.org/integration/autoland/rev/9aeccc359f05
[wpt PR 28252] - Update wpt metadata, a=testonly

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82c138b66d23
[wpt PR 28252] - URLPattern: Revamp baseURL second argument approach., a=testonly
https://hg.mozilla.org/integration/autoland/rev/55ae31e11878
[wpt PR 28252] - Update wpt metadata, a=testonly

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/82c138b66d23
https://hg.mozilla.org/mozilla-central/rev/55ae31e11878