1701162 - “Send Link to Device” context menu option is placed in its own section

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P3)

Description

[Emil Ghitta, QA [:emilghitta]]

Affected versions

• Firefox 89.0a1 (BuildId:20210325085523)
• Firefox 88.0b3 (BuildId:20210325185929)

Affected platforms

• macOS 10.14
• Windows 10 64bit
• Ubuntu 20.04

Preconditions

• Log in with a Firefox account which has multiple devices connected.

Steps to reproduce

1. Launch Firefox.
2. Access the following link
3. Right click on the image hyperlink.

Expected result

• The “Send Link to Device” option is positioned inside the same section in which the “Email Image…” option is placed (above the “Set Image as Desktop Background…” option) as per the approved specs.

Actual result

• The “Send Link to Device” option is positioned in it’s own section, under the “Set Image as Desktop Background…” option

Regression Range

• I don’t think that this is a regression.

Notes

• This issue can be seen with both proton enabled & proton disabled.

Comment 1

[Emil Ghitta, QA [:emilghitta]]

Attachment: Expected hyperlink context menu structure

Comment 2

[:Gijs (he/him)]

Bug 1700984 is a similar issue.

I'm actually not sure the structure in attachment 9211705 [details] (copied from the slide deck) is the right one. We were originally going to omit this menuitem for linked images entirely, but decided very recently not to do that.

The slide example is for a hyperlinked image, and "send link" sends the (hyper)link, not the image, so I'd expect the item to be either right before or right after "copy link". In link context menus, the slide deck has the "send link to device" item after "copy link" (rather than after "save link to pocket", before "copy link"), but in the main page context menus it has "send page" immediately after "save page to pocket". I think it'd be best for the placing to be consistent, and I suspect "copy link" is more frequently used than "send link to device" and so having "copy link" adjacent to the separator (by moving "send link to device" above it rather than below) would be preferable. Meridel, can you confirm what you would like us to do?

Comment 3

[Romain Testard [:RT]]

(In reply to :Gijs (he/him) from comment #2)

Bug 1700984 is a similar issue.

I'm actually not sure the structure in attachment 9211705 [details] (copied from the slide deck) is the right one. We were originally going to omit this menuitem for linked images entirely, but decided very recently not to do that.

The slide example is for a hyperlinked image, and "send link" sends the (hyper)link, not the image, so I'd expect the item to be either right before or right after "copy link". In link context menus, the slide deck has the "send link to device" item after "copy link" (rather than after "save link to pocket", before "copy link"), but in the main page context menus it has "send page" immediately after "save page to pocket". I think it'd be best for the placing to be consistent, and I suspect "copy link" is more frequently used than "send link to device" and so having "copy link" adjacent to the separator (by moving "send link to device" above it rather than below) would be preferable. Meridel, can you confirm what you would like us to do?

This sounds right to me, I'll let Meridel confirm we should follow Gijs suggestion.

Comment 4

[Meridel [:meridel]]

Thanks, Gijs. I agree with your recommendation— that placement aligns with the organization in the context menu for links, too. Deck has been updated and we can move ahead with new location.

Comment 5

[Michelle Goossens [:masterwayz]]

Attachment: Bug 1701162 - Move "Send Link to Device" context menu option below "Copy Link" r?emalysz

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1933588184c6
Move "Send Link to Device" context menu option below "Copy Link" r=emalysz

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1933588184c6

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Not sure this is worth taking this late in the 88 cycle. Feel free to say so if you disagree, however.

Comment 9

[Emil Ghitta, QA [:emilghitta]]

This is verified fixed using Firefox 89.0a1 (BuildId:20210414160838) on Windows 10 64bit, macOS 10.15 and Ubuntu 18.04.

The "Send link to Device" context menu option is positioned below the "Copy Link" option (as expected per the newly updated deck).