1701253 - Text in "Choose an application to open the <scheme> link" is illegible

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Roy Wellington]

Attachment: open-link-text.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

I opened a link that required the "Choose an application to open the $SCHEME link." dialog to appear. The dialog's listing of items, if selected, uses a black text on a blue background, which is IMO unreadable, and if not selected, uses black text on a dark grey background, which is definitely unreadable.

See the attached screenshot, which demonstrates the unselected state. (But, again, the selected state isn't much better.)

Note that I'm on OS X, using "dark mode", and running Firefox "Developer Edition".

My guess is that this is because I am using either dark mode in OS X, or Firefox Developer Edition (which seems to have a dark theme).

Cf. https://bugzilla.mozilla.org/show_bug.cgi?id=1700976 which is causing me to have to see this dialog a lot more than I should; there's another screenshot there showing the selected state.

Actual results:

The text was unreadable.

Expected results:

The text should be readable & use the system's color theme consistently.

Comment 1

[Roy Wellington]

Just to be clear: the illegible text in that screenshot is the "moz-extension://UUID", which is below "Open URL in a container".

Comment 2

[Andrei Purice]

Hey Roy,
This might be related to the theme you're using but still the text should be readable. Does it happen with other themes?

Can you test the issue while in Safe Mode? You can find helpful info here : https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode .
Also a fresh new profile could help. You can find more about creating a new profile here : https://support.mozilla.org/en-US/kb/troubleshoot-and-diagnose-firefox-problems#w_6-create-a-new-firefox-profile .
If possible, you can test this issue on the nightly build as well. Download the build from : https://www.mozilla.org/en-US/firefox/nightly/all/ .

Comment 3

[Roy Wellington]

This might be related to the theme you're using but still the text should be readable.

My understanding is that this is the default "theme" of Firefox Developer Edition. ("Dark", by Mozilla)
All of my installs of Firefox Developer Edition have used this theme.

Does it happen with other themes?

Yes, e.g., if I switch to Alpenglow, it renders the dialog the same. (I am wondering if it takes its theming queues not from the current theme, but from the system, and again, I run in OS X with Dark Mode.)

Can you test the issue while in Safe Mode?

No change in safe mode / same rendering.

(Your other two remarks will take me more time.)

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 5

[Markus Stange [:mstange]]

So one way to reproduce this seems to be:

1. Install https://addons.mozilla.org/en-US/firefox/addon/open-url-in-container/
2. Go to data:text/html,<a href="ext+container:name=MyContainer&url=https://mozilla.org">Mozilla.Org in MyContainer</a>
3. Click the link.
4. The protocol handler window opens.
5. Click "Choose a different application".

There's a color: GrayText in handling.css which probably needs to be replaced with an appropriate CSS variable for de-emphasized text in selected or non-selected items. Though there doesn't really seem to be a great match for that.

Comment 6

[:Gijs (he/him)]

We're hoping to overhaul the styling in bug 1697506. Meanwhile though, this information isn't critical, and this only happens with the dark theme, so I don't think this needs to be S3.

Comment 7

[Ada C.]

Hi, Roy

Tried to reproduce this on latest Nightly 124.0a1 (2024-02-16) using macOS 10.15, but I was unable to recreate the situation. Is this issue still reproducible for you?

Comment 8

[Cecile Treadwell]

Attachment: partjomaly19844880.txt

Thanks from lipestmantheo1978.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:amy, since the bug has recent activity, could you have a look please?

For more information, please visit BugBot documentation.

Comment 10

[Dão Gottwald [:dao]]

(In reply to Ada C. from comment #7)

Hi, Roy

Tried to reproduce this on latest Nightly 124.0a1 (2024-02-16) using macOS 10.15, but I was unable to recreate the situation. Is this issue still reproducible for you?

emilio says Graytext should adapt to dark mode these days, so this makes sense. Thanks for testing!