1701306 - Audit JS that sets `open=true` on anchors to see if that's still necessary after bug 1694285 lands

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

In bug 1694285, I made it so that open=true is set on the nearest toolbarbutton on an anchorNode (or the anchorNode if no toolbarbutton is found) by panel.js when an anchored panel is opened.

dao noted that there are a few places that try to do the same thing elsewhere in the front-end code that are now made redundant because of bug 1694285. See https://phabricator.services.mozilla.com/D109939#3575029.

This bug is for checking to see if those places are redundant and if they can be removed.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1701306 - Remove custom code setting the "open" attribute on panel anchors. r=mconley

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d8aa8575c1d
Remove custom code setting the "open" attribute on panel anchors. r=mconley

Comment 3

[Alexandru Michis [:malexandru]]

Backed out changeset 8d8aa8575c1d (Bug 1701306) for causing multiple bc failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/f85284243a8147658e980a507ca9624948f68926
Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=f85284243a8147658e980a507ca9624948f68926&fromchange=5c6a0c43dfd88552c96b89c11ad0d67846f202bc&searchStr=bc

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/034a69e0a73e
Remove custom code setting the "open" attribute on panel anchors. r=mconley

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing browser-chrome failures in browser_page_action_menu

Backout link: https://hg.mozilla.org/integration/autoland/rev/98fbdf08cf7a66f0230c5cf280edaa94d4ea9d63

Push with failures

Failure log

Comment 6

[Dão Gottwald [:dao]]

This is green on try: https://treeherder.mozilla.org/jobs?repo=try&revision=9d3601de7432feaa04ad5c7900ee3e68fec22cc0
I'm guessing something around browser_page_action_menu.js and proton changed in the meantime.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1f9288defa1
Remove custom code setting the "open" attribute on panel anchors. r=mconley

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c1f9288defa1