Closed Bug 1701325 Opened 5 years ago Closed 5 years ago

Reconsider (again) the amount of space used by Proton tabs

Categories

(Firefox :: Tabbed Browser, defect)

Firefox 89
defect

Tracking

()

RESOLVED INVALID

People

(Reporter: u658943, Unassigned)

References

(Depends on 1 open bug)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

Enable Proton

Actual results:

Proton tabs (even after reconsideration and reduction here https://bugzilla.mozilla.org/show_bug.cgi?id=1698244) are still massive.

Expected results:

Please consider reducing the size of Proton tabs more. They are massive as it is at the moment. In the image I illustrated, it can clearly bee seen that the tabs have enough space in them to contain just over 4 times the height of the text in the tab.

It could be reduced to 2x the height of the text (accounting for aesthetic padding) rather than just under 4x the height. Doing this would alleviate many users' concerns about the removal of compact mode.

Attached image photon_example.jpg

Could it not at the very least be considered to resize Proton's tabs to around 3x the height of the text, as they are/were in Photon?

The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Tabbed Browser
Depends on: proton-tabs-bar

In the image I illustrated, it can clearly bee seen that the tabs have enough space in them to contain just over 4 times the height of the text in the tab.

This is clearly not true. One line is truncated and one line overflows the tab shape in your picture so you won't get the tab title four times in the tab. And if you're talking about the dimensions you have to consider the multi-line case (for example when playing a video) - what you didn't. It has to look good in this case as well. Please note that some spacing, unlike as in your picture, is needed above, below and between the lines so that it looks harmonious. Also note that other languages with different characters may have different requirements to be readable.

Any proposal should consider all these things.

I'm not sure about any future plans of changing this.
Jaws, could you please help us here to confirm or to close this issue?

Flags: needinfo?(jaws)

We're not planning to change the tab dimensions. I appreciate the feedback but I think we need to live with this longer before we can come to a new resolution as to if the size or shape needs to change again.

Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Flags: needinfo?(jaws)
Resolution: --- → INVALID

(In reply to Sören Hentzschel from comment #3)

In the image I illustrated, it can clearly bee seen that the tabs have enough space in them to contain just over 4 times the height of the text in the tab.

This is clearly not true. One line is truncated and one line overflows the tab shape in your picture so you won't get the tab title four times in the tab.
Yes, it was a mistake. I meant to say "under" rather than "over".

And if you're talking about the dimensions you have to consider the multi-line case (for example when playing a video) - what you didn't.
In photon, all this was on the same line. Though from what you've said I imagine this is part of the Proton specification.

It has to look good in this case as well. Please note that some spacing, unlike as in your picture, is needed above, below and between the lines so that it looks harmonious.
As I outlined, I said that some aesthetic padding is needed. Such as was the case in Photon.

Also note that other languages with different characters may have different requirements to be readable.
Fair enough, but again this was fine in Photon where the tabs were smaller.

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5)

We're not planning to change the tab dimensions. I appreciate the feedback but I think we need to live with this longer before we can come to a new resolution as to if the size or shape needs to change again.

Alright. Thanks for looking at it.

And apologies I messed up the formatting above.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: