1701340 - [wpt-sync] Sync PR 28265 - Merge constants.js and websocket.sub.js

Status: RESOLVED FIXED

(Core :: Networking: WebSockets, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 28265 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28265
Details from upstream follow.

b'Arno Renevier <[e-mail]>' wrote:

Merge constants.js and websocket.sub.js

Right now, we have tests using constants.js and websocket.sub.js

Instead, we merge all the functionality into one unique file
constants.sub.js

The test don't have to specify if the Websocket whether secure anymore.
Instead, we run the 3 variants (unsecure, secure and http2) whenever
possible.

Since some tests were duplicated between a Secure and regular version,
we can now get rid of one those two versions.

We also remove Create-Secure-verify-url-set-non-default-port.any.js and
Create-verify-url-set-non-default-port.any.js which seems to have been
obsolete for some time.

Fixes #28264

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=636bbad6282da6fea0d6a83bbd6706e02973e1eb

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 712 tests and 1 subtests

## Status Summary

### Firefox
OK     : 478[Gecko-linux1804-64-tsan-opt] 487[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview] 491[Gecko-linux1804-64-debug, Gecko-linux1804-64-qr-debug] 492[Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 493[Gecko-linux1804-64-opt] 536[Gecko-windows7-32-debug] 544[Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug] 549[Gecko-windows10-64-opt, Gecko-windows10-64-qr-opt] 712[GitHub]
PASS   : 1630[Gecko-linux1804-64-tsan-opt] 1657[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview] 1662[Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 1781[Gecko-linux1804-64-debug] 1783[Gecko-linux1804-64-opt] 1784[Gecko-linux1804-64-qr-debug] 1864[Gecko-windows7-32-debug] 1866[Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug] 1871[Gecko-windows10-64-opt, Gecko-windows10-64-qr-opt] 2169[GitHub]
CRASH  : 4[Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows7-32-debug] 6[Gecko-android-em-7.0-x86_64-debug-geckoview]
FAIL   : 179[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-tsan-opt] 283[Gecko-windows7-32-debug] 344[Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt] 346[GitHub]
TIMEOUT: 8[Gecko-windows7-32-debug] 49[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview] 51[Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 62[Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug] 63[Gecko-linux1804-64-debug] 76[Gecko-linux1804-64-tsan-opt]
ERROR  : 1[Gecko-linux1804-64-tsan-opt] 10[Gecko-android-em-7.0-x86_64-opt-geckoview] 12[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 14[Gecko-android-em-7.0-x86_64-qr-debug-geckoview]

### Chrome
OK     : 603
PASS   : 2097
FAIL   : 229
TIMEOUT: 123
ERROR  : 6
NOTRUN : 169

### Safari
OK     : 553
PASS   : 1815
FAIL   : 371
TIMEOUT: 188
ERROR  : 17
NOTRUN : 176

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=636bbad6282da6fea0d6a83bbd6706e02973e1eb)
[GitHub PR Head](https://wpt.fyi/results/?sha=514b44c381b393cebe9450fdb4d1f4e620c9accf&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=514b44c381b393cebe9450fdb4d1f4e620c9accf&label=pr_base)

## Details

### Crashes
/websockets/basic-auth.any.worker.html?wpt_flags=h2: CRASH [`Gecko-android-em-7.0-x86_64-debug-geckoview`, `Gecko-android-em-7.0-x86_64-qr-debug-geckoview`, `Gecko-windows10-64-debug`, `Gecko-windows10-64-qr-debug`, `Gecko-windows7-32-debug`], OK [`Gecko-android-em-7.0-x86_64-opt-geckoview`, `Gecko-android-em-7.0-x86_64-qr-opt-geckoview`, `Gecko-windows10-64-opt`, `Gecko-windows10-64-qr-opt`, `GitHub`], TIMEOUT [`Gecko-linux1804-64-debug`, `Gecko-linux1804-64-opt`, `Gecko-linux1804-64-qr-debug`, `Gecko-linux1804-64-tsan-opt`]
/websockets/basic-auth.any.sharedworker.html?wpt_flags=h2: CRASH [`Gecko-android-em-7.0-x86_64-debug-geckoview`, `Gecko-android-em-7.0-x86_64-qr-debug-geckoview`, `Gecko-windows10-64-debug`, `Gecko-windows10-64-qr-debug`, `Gecko-windows7-32-debug`], OK [`Gecko-android-em-7.0-x86_64-opt-geckoview`, `Gecko-android-em-7.0-x86_64-qr-opt-geckoview`, `Gecko-windows10-64-opt`, `Gecko-windows10-64-qr-opt`, `GitHub`], TIMEOUT [`Gecko-linux1804-64-debug`, `Gecko-linux1804-64-opt`, `Gecko-linux1804-64-qr-debug`, `Gecko-linux1804-64-tsan-opt`]
/websockets/basic-auth.any.serviceworker.html?wpt_flags=h2: CRASH [`Gecko-android-em-7.0-x86_64-debug-geckoview`, `Gecko-android-em-7.0-x86_64-qr-debug-geckoview`, `Gecko-windows10-64-debug`, `Gecko-windows10-64-qr-debug`, `Gecko-windows7-32-debug`], OK [`Gecko-android-em-7.0-x86_64-opt-geckoview`, `Gecko-android-em-7.0-x86_64-qr-opt-geckoview`, `Gecko-windows10-64-opt`, `Gecko-windows10-64-qr-opt`, `GitHub`], TIMEOUT [`Gecko-linux1804-64-debug`, `Gecko-linux1804-64-opt`, `Gecko-linux1804-64-qr-debug`, `Gecko-linux1804-64-tsan-opt`]
/websockets/basic-auth.any.html?wpt_flags=h2: CRASH [`Gecko-android-em-7.0-x86_64-debug-geckoview`, `Gecko-android-em-7.0-x86_64-qr-debug-geckoview`, `Gecko-windows10-64-debug`, `Gecko-windows10-64-qr-debug`, `Gecko-windows7-32-debug`], OK [`Gecko-android-em-7.0-x86_64-opt-geckoview`, `Gecko-android-em-7.0-x86_64-qr-opt-geckoview`, `Gecko-windows10-64-opt`, `Gecko-windows10-64-qr-opt`, `GitHub`], TIMEOUT [`Gecko-linux1804-64-debug`, `Gecko-linux1804-64-opt`, `Gecko-linux1804-64-qr-debug`, `Gecko-linux1804-64-tsan-opt`]
/websockets/extended-payload-length.html?wpt_flags=h2: CRASH [`Gecko-android-em-7.0-x86_64-opt-geckoview`], ERROR [`Gecko-android-em-7.0-x86_64-qr-debug-geckoview`], OK [`Gecko-windows10-64-debug`, `Gecko-windows10-64-opt`, `Gecko-windows10-64-qr-debug`, `Gecko-windows10-64-qr-opt`, `Gecko-windows7-32-debug`, `GitHub`], TIMEOUT [`Gecko-android-em-7.0-x86_64-debug-geckoview`, `Gecko-android-em-7.0-x86_64-qr-opt-geckoview`, `Gecko-linux1804-64-debug`, `Gecko-linux1804-64-opt`, `Gecko-linux1804-64-qr-debug`, `Gecko-linux1804-64-tsan-opt`]
/websockets/binary/005.html?wpt_flags=h2: CRASH [`Gecko-android-em-7.0-x86_64-opt-geckoview`], ERROR [`Gecko-android-em-7.0-x86_64-debug-geckoview`, `Gecko-android-em-7.0-x86_64-qr-debug-geckoview`, `Gecko-android-em-7.0-x86_64-qr-opt-geckoview`], OK [`Gecko-linux1804-64-debug`, `Gecko-linux1804-64-opt`, `Gecko-linux1804-64-qr-debug`, `Gecko-windows10-64-debug`, `Gecko-windows10-64-opt`, `Gecko-windows10-64-qr-debug`, `Gecko-windows10-64-qr-opt`, `Gecko-windows7-32-debug`, `GitHub`], TIMEOUT [`Gecko-linux1804-64-tsan-opt`]
/websockets/constructor/005.html?wpt_flags=h2: CRASH [`Gecko-android-em-7.0-x86_64-debug-geckoview`], ERROR [`Gecko-android-em-7.0-x86_64-qr-debug-geckoview`, `Gecko-android-em-7.0-x86_64-qr-opt-geckoview`], OK [`Gecko-linux1804-64-debug`, `Gecko-linux1804-64-opt`, `Gecko-linux1804-64-qr-debug`, `Gecko-windows10-64-debug`, `Gecko-windows10-64-opt`, `Gecko-windows10-64-qr-debug`, `Gecko-windows10-64-qr-opt`, `Gecko-windows7-32-debug`, `GitHub`], TIMEOUT [`Gecko-android-em-7.0-x86_64-opt-geckoview`, `Gecko-linux1804-64-tsan-opt`]
/websockets/constructor/019.html?wpt_flags=h2: CRASH [`Gecko-android-em-7.0-x86_64-opt-geckoview`], OK [`Gecko-linux1804-64-debug`, `Gecko-linux1804-64-opt`, `Gecko-linux1804-64-qr-debug`, `Gecko-windows10-64-debug`, `Gecko-windows10-64-opt`, `Gecko-windows10-64-qr-debug`, `Gecko-windows10-64-qr-opt`, `Gecko-windows7-32-debug`, `GitHub`], TIMEOUT [`Gecko-android-em-7.0-x86_64-debug-geckoview`, `Gecko-android-em-7.0-x86_64-qr-debug-geckoview`, `Gecko-android-em-7.0-x86_64-qr-opt-geckoview`, `Gecko-linux1804-64-tsan-opt`]
/websockets/interfaces/CloseEvent/clean-close.html?wpt_flags=h2: CRASH [`Gecko-android-em-7.0-x86_64-opt-geckoview`], ERROR [`Gecko-android-em-7.0-x86_64-debug-geckoview`, `Gecko-android-em-7.0-x86_64-qr-opt-geckoview`], OK [`Gecko-linux1804-64-debug`, `Gecko-linux1804-64-opt`, `Gecko-linux1804-64-qr-debug`, `Gecko-windows10-64-debug`, `Gecko-windows10-64-opt`, `Gecko-windows10-64-qr-debug`, `Gecko-windows10-64-qr-opt`, `Gecko-windows7-32-debug`, `GitHub`], TIMEOUT [`Gecko-android-em-7.0-x86_64-qr-debug-geckoview`, `Gecko-linux1804-64-tsan-opt`]
/websockets/opening-handshake/001.html?wpt_flags=h2: CRASH [`Gecko-android-em-7.0-x86_64-debug-geckoview`], OK [`Gecko-windows10-64-debug`, `Gecko-windows10-64-opt`, `Gecko-windows10-64-qr-debug`, `Gecko-windows10-64-qr-opt`, `Gecko-windows7-32-debug`, `GitHub`], TIMEOUT [`Gecko-android-em-7.0-x86_64-opt-geckoview`, `Gecko-android-em-7.0-x86_64-qr-debug-geckoview`, `Gecko-android-em-7.0-x86_64-qr-opt-geckoview`, `Gecko-linux1804-64-debug`, `Gecko-linux1804-64-opt`, `Gecko-linux1804-64-qr-debug`, `Gecko-linux1804-64-tsan-opt`]

### Firefox-only Failures
/websockets/Create-asciiSep-protocol-string.any.worker.html
  Create WebSocket - Pass a valid URL and a protocol string with an ascii separator character - SYNTAX_ERR is thrown: FAIL
/websockets/Create-asciiSep-protocol-string.any.worker.html?wss
  Create WebSocket - Pass a valid URL and a protocol string with an ascii separator character - SYNTAX_ERR is thrown: FAIL
/websockets/Create-asciiSep-protocol-string.any.html
  Create WebSocket - Pass a valid URL and a protocol string with an ascii separator character - SYNTAX_ERR is thrown: FAIL
/websockets/Create-asciiSep-protocol-string.any.html?wpt_flags=h2
  Create WebSocket - Pass a valid URL and a protocol string with an ascii separator character - SYNTAX_ERR is thrown: FAIL
/websockets/Create-asciiSep-protocol-string.any.html?wss
  Create WebSocket - Pass a valid URL and a protocol string with an ascii separator character - SYNTAX_ERR is thrown: FAIL
/websockets/Create-asciiSep-protocol-string.any.worker.html?wpt_flags=h2
  Create WebSocket - Pass a valid URL and a protocol string with an ascii separator character - SYNTAX_ERR is thrown: FAIL

(See attachment for full changes)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d014d19ed63
[wpt PR 28265] - Merge constants.js and websocket.sub.js, a=testonly
https://hg.mozilla.org/integration/autoland/rev/c5474768046b
[wpt PR 28265] - Update wpt metadata, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64c23da7df4b
[wpt PR 28265] - Merge constants.js and websocket.sub.js, a=testonly
https://hg.mozilla.org/integration/autoland/rev/aa3fd3cc371d
[wpt PR 28265] - Update wpt metadata, a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6168ec24f70b
[wpt PR 28265] - Merge constants.js and websocket.sub.js, a=testonly
https://hg.mozilla.org/integration/autoland/rev/738702034261
[wpt PR 28265] - Update wpt metadata, a=testonly

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96f61d2ca71a
[wpt PR 28265] - Merge constants.js and websocket.sub.js, a=testonly
https://hg.mozilla.org/integration/autoland/rev/e32ed5b9b0b3
[wpt PR 28265] - Update wpt metadata, a=testonly

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/96f61d2ca71a
https://hg.mozilla.org/mozilla-central/rev/e32ed5b9b0b3